Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaves - Samantha & Yasmin #25

Open
wants to merge 86 commits into
base: master
Choose a base branch
from
Open

Conversation

iamsammysam
Copy link

Rideshare-Rails

Congratulations! You're submitting your assignment! These comprehension questions should be answered by both partners together, not by a single teammate.

Comprehension Questions

Question Answer
Describe the types of entity relationships you set up in your project and why you set up the relationships that way One driver has many trips and one passenger has many trips. Because one driver can do many trips and one passenger can request many trips.
Describe the role of model validations in your application The model validations for Driver exist so we can’t create a driver without a name or a vin. For the Passenger exist so we can’t create a passenger without a name or a phone number.
How did your team break up the work to be done? We divided the work at the beginning so one person worked on the driver features and the other person worked on the passenger. Later on we divided the work to fix bugs and create tests.
What features did you choose to prioritize in your project, and what features, if any, did you have to set aside to meet the deadline? The toggle button to change the driver status from active to inactive.
What was one thing that your team collectively gained more clarity on after completing this assignment? We feel more comfortable with the rails files but we need to work on understanding how the routes connect with the controller.
What is your Trello board URL? https://trello.com/b/Zx07QkIG/ada-projects-ride-share
What is the Heroku URL of your deployed application? https://adies-rideshare-ys.herokuapp.com/
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share? We learned how to work together.

@beccaelenzil
Copy link

Rideshare Rails

What We're Looking For

Feature Feedback
Baseline
Appropriate git usage with no extraneous files checked in and all team members contributing check
Answered comprehension questions check
Uses named routes (like _path) check
RESTful routes utilized check
Project Requirements
Table relationships check
Validation rules for Models check
Business logic is in the models check
Tests for validations check
Tests for relationships check
Tests for custom model methods check
Tests for controller actions check
Database is seeded from the CSV files check
Trello board is created and utilized in project management check
Heroku instance is online check
The app is styled to create an attractive user interface just a couple suggestions -- it would be nice if you could request a trip from the show passenger view and it would be nice to receive a "polite" message when making a new driver/passenger and validations fail.
Overall Great job overall. This code is well-written and well-tested. It is clear that the learning goals around model relationships, validations, and seeding were met. Keep up the hard work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants