Branches - Sara and Linnea

[llinneaa]

Rideshare-Rails

Congratulations! You're submitting your assignment! These comprehension questions should be answered by both partners together, not by a single teammate.

Comprehension Questions

Question	Answer
Describe the types of entity relationships you set up in your project and why you set up the relationships that way	One to many relationships between Passenger/Trip and Driver/Trips. They were set up this way because each instance of Passenger/Driver has many Trips, but each instance of Trip has only one Passenger/Driver.
Describe the role of model validations in your application	The model validations ensure the program receives all valid parameters and only valid data are saved to the database.
How did your team break up the work to be done?	One of us worked on Driver mainly and the other worked on Passenger, including all the tests. One completed the CSS styling while the other did Trips. We worked on a lot of the tests together.
What features did you choose to prioritize in your project, and what features, if any, did you have to set aside to meet the deadline?	We chose to prioritize making our database information appear correctly on the app and make sure all the calculations were done correctly. We completed the required tests, but could have done more.
What was one thing that your team collectively gained more clarity on after completing this assignment?	The functions of M/V/C.
What is your Trello board URL?	https://trello.com/b/8fBR4CBs/rideshare-rails
What is the Heroku URL of your deployed application?	https://sara-linnea-rideshare-rails.herokuapp.com/
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share?	1. Willing to talk through conflicting ways of problem solving; 2. We discussed git workflow extensively and chose to only work on separate branches (outside of the master) until we were ready to push/deploy.

[tildeee]

Rideshare Rails

What We're Looking For

Feature	Feedback
Baseline
Appropriate git usage with no extraneous files checked in and all team members contributing	x
Answered comprehension questions	x
Uses named routes (like _path)	x
RESTful routes utilized	x
Project Requirements
Table relationships	x
Validation rules for Models	x
Business logic is in the models	x
Tests for validations	missing
Tests for relationships	x
Tests for custom model methods	lacks all of the edge case tests
Tests for controller actions	x
Database is seeded from the CSV files	x
Trello board is created and utilized in project management	x
Heroku instance is online	x
The app is styled to create an attractive user interface	x
Overall

Great work on this project!

The biggest issue I saw with this is that you all missed tests on validations on all of your models. Reach out to me so we can talk about any issues that came up.

In your drivers_controller_test.rb, in the update action, I recommend that you all rework the syntax so it uses the strong params method.

You two have one big bug: When deleting a driver or a passenger, if the driver or passenger still has trips associated with them, your app will not deal well with the views of the associated trips and drivers.

To reproduce:

• Find a passenger (Passenger A) who has gone on at least one trip (Trip A, with Driver A)
• Delete Passenger A
• Go to the show page of Trip A, observe that it is broken
• Go to the show page of Driver A, observe that it is broken

One nitpick: In your driver_test.rb file, your indentation is off by one space. Be mindful of this! Similarly, in the drivers_controller_test.rb, some blocks are indented too much.

Another nitpick: In your driver_test, you all added a lot of statements to save the driver/passenger... Try commenting every line that has .save. The tests probably still pass! In model tests, you likely won't need to call .save

Your implementation code is great, but there are areas of improvements on the tests and some best practices (strong params, indentation). Let me know if you have questions, but good work you two!