vi & erika - branches

[criacuervos]

Rideshare-Rails

Congratulations! You're submitting your assignment! These comprehension questions should be answered by both partners together, not by a single teammate.

Comprehension Questions

Question	Answer
Describe the types of entity relationships you set up in your project and why you set up the relationships that way	We created our drivers and passengers to have many trips, and trips to belong to driver and passengers. Realistically it made a lot of sense to set it up this way because when we drew it out, we decided that there was a one(passenger) to many(trips) relationship.
Describe the role of model validations in your application	These were super helpful! With our model validations, we ensured that, for example, a trip could only exist if it had a driver and a passenger. Or, you wouldn't be able to create a passenger without a name, which would be a waste of time and space in any real program!
How did your team break up the work to be done?	Driver and passenger were pretty parallel, so it was pretty useful to be able to divide up testing and writing in controllers and methods based off that. If we got stuck, we usually both got stuck on the same thing.
What features did you choose to prioritize in your project, and what features, if any, did you have to set aside to meet the deadline?	I think that we prioritized functionality first. Every passenger has a create trip button on their page that works. Ensuring that the routes were perfect, and that navigation was clear and on every page was also super important.
What was one thing that your team collectively gained more clarity on after completing this assignment?	We both gained clarity on the responsibility of each aspect of the MVC. While in theory we were aware of their general purpose, seeing where their methods and actions actually go and when to use each one was super demystifying and helpful!
What is your Trello board URL?	https://trello.com/b/EQR8qltL/rideshare
What is the Heroku URL of your deployed application?	https://erika-v-rideshare.herokuapp.com/
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share?	We acknowledged the role we played in helping one another and how we positively contributed to each others learning processes!

[jmaddox19]

Rideshare Rails

What We're Looking For

Feature	Feedback
Baseline
Appropriate git usage with no extraneous files checked in and all team members contributing	X
Answered comprehension questions	X
Uses named routes (like _path)	X
RESTful routes utilized	Yes! Though I don't see how the nested route drivers/:driver_id/trips/... can get reached.
Project Requirements
Table relationships	X
Validation rules for Models	X
Business logic is in the models	X
Tests for validations	X
Tests for relationships	When I debug into the relationships test for driver, I see the driver has no trips. Not sure how this is passing...
Tests for custom model methods	No :/
Tests for controller actions	Not required
Database is seeded from the CSV files	X
Trello board is created and utilized in project management	X
Heroku instance is online	Yes!
The app is styled to create an attractive user interface	Yes!
Overall	Y'all should be proud of what you did! Enough of the functionality is resulting in a "something went wrong" error that the submission is a yellow but still good job! (A couple things I tried that caused it: editing trip cost and submitting a rating. Also there wasn't a cost given to a new trip.