Branches - Xinran and Amal

[ashassan]

Rideshare-Rails

Congratulations! You're submitting your assignment! These comprehension questions should be answered by both partners together, not by a single teammate.

Comprehension Questions

Question	Answer
Describe the types of entity relationships you set up in your project and why you set up the relationships that way	We have a driver that has many trips and a passenger that has many trips. We set it up this way cause both a passenger and a driver can go on many trips.
Describe the role of model validations in your application	To make sure that we get the information needed for the app to function.
How did your team break up the work to be done?	One person worked on the passenger and one person worked on the driver. We used liveshare so we can work side by side.
What features did you choose to prioritize in your project, and what features, if any, did you have to set aside to meet the deadline?	We prioritized the controllers and the routes. We made the css the lowest priority.
What was one thing that your team collectively gained more clarity on after completing this assignment?	We gained more clarity on nested routes and using model methods that connect to controllers and views.
What is your Trello board URL?	https://trello.com/invite/b/5J55KdcS/626a966836e0a53954b8ca04f66b7487/ride-share-rails
What is the Heroku URL of your deployed application?	https://murmuring-refuge-50537.herokuapp.com/
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share?	We helped each other to understand the concepts better. We shared the workload evenly and were always on the same page.

[tildeee]

Rideshare Rails

What We're Looking For

Feature	Feedback
Baseline
Appropriate git usage with no extraneous files checked in and all team members contributing	x
Answered comprehension questions	x
Uses named routes (like _path)	x
RESTful routes utilized	x
Project Requirements
Table relationships	x
Validation rules for Models	x
Business logic is in the models	x
Tests for validations	x
Tests for relationships	x
Tests for custom model methods	x
Tests for controller actions	x
Database is seeded from the CSV files	x
Trello board is created and utilized in project management	x
Heroku instance is online	x
The app is styled to create an attractive user interface	x
Overall

Great work on this project, you two! The test code looks great and thorough and great! And the app code looks elegant and follows all the best practices!

You two have one big bug: Deleting a driver or a passenger with trips doesn't work!

When deleting a driver or a passenger, if the driver or passenger still has trips associated with them, then your Rails app doesn't allow it! Looking at your code, it looks like you all anticipated that with the relationship in Driver: has_many :trips, dependent: :restrict_with_error. If that is true that it's intentional, then the next best thing to do is to provide feedback to your users using a flash message.

That being said, overall this is a great project! Also, the site is very very cute :) Good job, and keep up the hard work!