Branches- Dora & Mac (MacDora) #15

mdove92 · 2019-10-11T23:28:17Z

Rideshare-Rails

Congratulations! You're submitting your assignment! These comprehension questions should be answered by both partners together, not by a single teammate.

Comprehension Questions

Question	Answer
Describe the types of entity relationships you set up in your project and why you set up the relationships that way	Passengers and Drivers both have zero or many trips, but each trip has only one passenger and driver. Setting it up this way helps prevent redundancy. The data will not overlap in unintended ways.
Describe the role of model validations in your application	Model validations do not allow for bad data. Adding in the validations prevents a user from creating instances with missing attributes.
How did your team break up the work to be done?	We used a Trello board and did frequent checkins and an end of day standup.
What features did you choose to prioritize in your project, and what features, if any, did you have to set aside to meet the deadline?	CRUD was our first priority for both Passenger and Driver. Custom model methods for driver was another priority, and the new trip request for Passenger. Some testing fell through the cracks at the end.
What was one thing that your team collectively gained more clarity on after completing this assignment?	The benefits of using a Trello board! Also, needing to break big tests into their smaller components.
What is your Trello board URL?	https://trello.com/b/uPDI58T5/rails-rideshare
What is the Heroku URL of your deployed application?	https://macdora-catbus-rideshare.herokuapp.com/
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share?	We communicated well and often. We were honest with each other when we weren't able to complete work that we had hoped to. Our team morale was always high. So cohesive. We fist-bumped frequently.

…ntrollers and routes.

…en trips and passengers/driver.

…eated and functional

…s to Driver and Passenger

…bute of phone_num

…dit buttons to their views

…successful creation of new driver and passenger.

…ing all Passenger tests except for the one about having trips

… a driver's rides and find average rating

…d passengers controller for render _path

…for toggle and the corresponding routes

… adjusted models to pass tests.

…ed create trip action to get first inactive driver.

…rresponding route with no success

…roller_test for custom methods

…ange and act

…. COmmented out errored tests

jmaddox19 · 2019-10-21T20:58:13Z

Rideshare Rails

What We're Looking For

I love the theme and homepage! So fun and clever :)

One callout: Trips model is missing tests.

Great job y'all!

jmaddox19

Great job!

jmaddox19 · 2019-10-21T20:49:48Z

app/controllers/drivers_controller.rb

+    @driver.name = params[:driver][:name]
+    @driver.vin = params[:driver][:vin]
+    @driver.car_make = params[:driver][:car_make]
+    @driver.car_model = params[:driver][:car_model]
+    @driver.active = params[:driver][:active]


Minor: could have used driver_params here

[email protected] and others added 30 commits October 7, 2019 16:29

Created projects files. Added Passengers, Trips, Drivers, Homepage co…

621ac3b

…ntrollers and routes.

Added driver, passenger, and trip models. Added foreign keys to trips

892031d

Added minitest requirements to test helper. Added relationships betwe…

45755ba

…en trips and passengers/driver.

Drivers and Passengers #index, #show and respective html.erb files cr…

33a900c

…eated and functional

Trip#show created and show.html.erb functional

e73e915

added new passenger and new driver methods with matching views

175b58d

Oops - added the actions for new passenger this time

012a87e

Added Passenger and Driver view for Edit action and added edit action…

9d522ff

…s to Driver and Passenger

Added some validation for passengers and drivers

31ec669

Added error messages to validation for Driver and Passenger forms

fd5719f

Changed passenger test so that phone_number matched our defined attri…

8e39535

…bute of phone_num

Changed passenger test so that phone_number matched our defined attri…

f4987ff

…bute of phone_num

Created delete action for driver and passenger and added delete and e…

3d0ccd8

…dit buttons to their views

Added columns for drivers table

cb99e03

updated params for drivers and passengers update function

c68d4f1

Add link for creating new driver and passenger. Updated redirect for …

fe2ee7f

…successful creation of new driver and passenger.

updated driver's new and edit form to add in additional columns

b485755

Changed the driver and passenger validations to be more general. Pass…

4a508af

…ing all Passenger tests except for the one about having trips

Working on drivers controller test

c82c160

attempted to add simplecov. Added methods into driver models to count…

8b8c77a

… a driver's rides and find average rating

Merge branch 'mac_test_edits'

5388a3f

Added drivers controller tests

67dfc3e

Added passengers controller tests. Need to write tests for drivers an…

8f14bef

…d passengers controller for render _path

Updated trips routes

16ffc17

Adjusted driver model methods

3729cf2

Adding drivers&passengers controller #index tests

6289890

added table of all driver trips in driver show view

ad9dd6d

added css formatting to all driver trips table

3d3a76f

Merge branch 'master' of https://github.com/mdove92/ride-share-rails

1c138e7

updated routes to add trips

b760669

[email protected] and others added 28 commits October 9, 2019 14:28

Added delete button to trips show page

65d1178

Added driver and passenger details table to the show pages

54528a6

Created total_earnings method for driver model

852de48

updated instance variable in trips html

805c5b9

trips controller tests for #index, #show and #new completed and passed

cf4e1bb

added Driver Model toggle_active method and driver controller action …

a1e8dd6

…for toggle and the corresponding routes

Adjusted the driver test to match active status

83f2371

added some lines for Trips#create controller test

4dfea68

Began writing tests for custom methods for Driver Model

41a3b6b

Passenger can make new trip

1556a2b

Merge branch 'master' of https://github.com/mdove92/ride-share-rails

470d729

CSS for Homepage#index, Drivers#index and Passengers#index complete

19c9adb

homepage CSS final draft

78508de

drivers and passengers index page CSS final draft

391353e

CSS style added to drivers and passengers show page

c7f16eb

final draft completed for CSS

4d1a1a0

Added more model tests in driver and passenger for custom methods and…

1de357b

… adjusted models to pass tests.

Merge branch 'master' of https://github.com/mdove92/ride-share-rails

331d5e1

Added trips controller routes to Create new trip without form. Adjust…

d3dfc64

…ed create trip action to get first inactive driver.

Began passenger trip rating option in passenger show. Tried to add co…

9189f64

…rresponding route with no success

Made rate trip method for passengers that changes driver's active status

e1252e8

Added model test for count_rides and add templates dor passenger cont…

937746a

…roller_test for custom methods

COntinuing to add testing to passenger control and model

f4d0832

Removed error in view for editing trip

3a299fb

ADjusted passenger controller test for trip rating to have proper arr…

e882263

…ange and act

css for trips

fb2ff4d

Adjusted tests to remove errors

c868149

Made edits to trips_contorller test to add testing for custom methods…

63c4671

…. COmmented out errored tests

jmaddox19 reviewed Oct 21, 2019

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Branches- Dora & Mac (MacDora) #15

Branches- Dora & Mac (MacDora) #15

mdove92 commented Oct 11, 2019

jmaddox19 commented Oct 21, 2019

jmaddox19 left a comment

jmaddox19 Oct 21, 2019

Branches- Dora & Mac (MacDora) #15

Are you sure you want to change the base?

Branches- Dora & Mac (MacDora) #15

Conversation

mdove92 commented Oct 11, 2019

Rideshare-Rails

Comprehension Questions

jmaddox19 commented Oct 21, 2019

Rideshare Rails

What We're Looking For

jmaddox19 left a comment

Choose a reason for hiding this comment

jmaddox19 Oct 21, 2019

Choose a reason for hiding this comment