Leaves - Elizabeth and Morgan

[morganschuler]

Rideshare-Rails

Congratulations! You're submitting your assignment! These comprehension questions should be answered by both partners together, not by a single teammate.

Comprehension Questions

Question	Answer
Describe the types of entity relationships you set up in your project and why you set up the relationships that way	A trip belongs to passengers and drivers, and both driver and passengers have many trips. We set it up that way to reflect the links between the different players in our program.
Describe the role of model validations in your application	We validate user input when adding a new passenger or driver, or when editing a new passenger or driver with a very polite message!
How did your team break up the work to be done?	We began by doing pair-programming to understand better how we wanted to structure our project. Then, once we had a better idea of the direction we wanted our app to go in, we created branches and broke up the work based on passenger and driver. Then, the morning following we would compare our work.
What features did you choose to prioritize in your project, and what features, if any, did you have to set aside to meet the deadline?	We chose to prioritize the ratings and available/unavailable feature as a way to connect the passenger, trip, and driver. However, we did manage to include all of the functionality we had hoped for. We had to set aside some of the model tests because we weren't sure of the best way to test this aspect of our program and ran short on time.
What was one thing that your team collectively gained more clarity on after completing this assignment?	We gained more clarity on foreign keys and migrating.
What is your Trello board URL?	https://trello.com/b/X4tkSGJC/rideshare
What is the Heroku URL of your deployed application?	https://m-e-rideshare.herokuapp.com/
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share?	We agreed that we both have a direct communication style and this benefitted us in that we both felt we could express ourselves in the ways that felt natural. We thought we did well when splitting up the work and coming back together to compare/ask questions if any about what the other person did.

[beccaelenzil]

Rideshare Rails

What We're Looking For

Feature	Feedback
Baseline
Appropriate git usage with no extraneous files checked in and all team members contributing	check
Answered comprehension questions	check
Uses named routes (like _path)	check
RESTful routes utilized	check
Project Requirements
Table relationships	check
Validation rules for Models	check
Business logic is in the models	check -- calculating cost doesn't work as expected. I created a new trip, and the cost was $0. This shows up as a failure with your tests, so good job testing for this :) -- now your job is to correct the logic.
Tests for validations	there are errors in these tests -- Week 11's lessons should help with this, let me know if you have questions.
Tests for relationships	there are errors in these tests -- Week 11's lessons should help with this, let me know if you have questions.
Tests for custom model methods	there are errors in these tests -- Week 11's lessons should help with this, let me know if you have questions.
Tests for controller actions	check
Database is seeded from the CSV files	check
Trello board is created and utilized in project management	check
Heroku instance is online	check
The app is styled to create an attractive user interface	check
Overall	Good job overall. This code is well-written and you did a good job putting the business logic in the model. It is clear to me that the learning goals around model relationships, validations, and seeding were met. There is one error in your calculating trip cost method and several errors in your model tests. I suspect the lessons on model testing this past week will answer those questions, but do let me know if you have questions. Keep up the hard work!