Daniela Sanchez - Leaves #41

dnsanche · 2019-09-10T03:35:39Z

:)

…mory complexity

CheezItMan

Not bad, you do have some issues especially with binary search. Take a look at your code and my pseudocode. Try to figure out what's going on.

CheezItMan · 2019-09-10T21:34:13Z

lib/using_restricted_array.rb

+
+  until array[index] == nil
+      array[index]
+      index += 1  


Do you need two variable?

CheezItMan · 2019-09-10T21:35:15Z

lib/using_restricted_array.rb

+
+  while array[middle] != value_to_find
+    if array[middle] < value_to_find
+      start = middle + 1


You should also recalculate middle if array[middle] < value_to_find

CheezItMan · 2019-09-10T21:36:18Z

lib/using_restricted_array.rb

+    if array[middle] < value_to_find
+      start = middle + 1
+    else array[middle] > value_to_find
+      middle = (start + middle - 1)/2


You also need to keep track of the end as well as the start. This isn't quite right.

dnsanche added 5 commits September 5, 2019 12:55

Finished 1,2,3rd methods, tests passing, haven't finished time and me…

70442ee

…mory complexity

Finished find_largest and find_smallest method

0669822

Finished reverse array

b4c431f

Finished coding. Time/Space complexity left

6846eb0

Finished the coments.

67087c3

CheezItMan reviewed Sep 10, 2019

View reviewed changes

Provide feedback