Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branches - C. Gutierrez #29

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -66,3 +66,4 @@ You can use your superdigit solution in the solution for refined_superdigit. Ca
## Problem Source

- [HackerRank Super Digit](https://www.hackerrank.com/challenges/super-digit/problem)

53 changes: 49 additions & 4 deletions lib/fibonacci.rb
Original file line number Diff line number Diff line change
@@ -1,8 +1,53 @@
# Improved Fibonacci

# Time Complexity - ?
# Space Complexity - ? (should be O(n))
# Time Complexity - O(n)
# Space Complexity - O(n) (should be O(n))
# Hint, you may want a recursive helper method
def fibonacci(n)


def fibonacci(target, ultimate = 1, pentultimate = 0, n = 2)
if target < 0
raise ArgumentError
elsif target == 0
return 0
elsif target == 1
return 1
end

if n == target
current = pentultimate + ultimate
return current
else
n += 1
holder = pentultimate + ultimate
pentultimate = ultimate
ultimate = holder
Comment on lines +21 to +23

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

return fibonacci(target, ultimate = ultimate, pentultimate = pentultimate, n = n)
end
end

# # # # brute force
# def fibonacci(target)
# if target < 0
# raise ArgumentError
# elsif target == 0
# return 0
# elsif target == 1
# return 1
# end

# ultimate = 1
# pentultimate = 0
# current = 1
# n = 2

# until n == target
# pentultimate = ultimate

# ultimate = current
# current = pentultimate + ultimate
# n += 1
# end

# return current

# end
41 changes: 31 additions & 10 deletions lib/super_digit.rb
Original file line number Diff line number Diff line change
@@ -1,15 +1,36 @@
# Superdigit

# Time Complexity - ?
# Space Complexity - ?
def super_digit(n)

# Time Complexity - O(n)
# Space Complexity - O(log n)
Comment on lines +3 to +4

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same time/space complexity O(log10n)


def super_digit(input)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

# # # # brute recursion
if input < 10
return input
elsif input >= 10
sum = 0
i = 0
limit = input.to_s.length
dig_input = input.to_s
until i == limit
sum += dig_input[i].to_i
i += 1
end
return super_digit(sum)
end
end


# Time Complexity - ?
# Space Complexity - ?
def refined_super_digit(n, k)

# Time Complexity - O(n)
# Space Complexity - O(m log n)

# This method uses the super_digit method as a helper as I'm too lazy to write it again.
def refined_super_digit(number, repeater)
assembled_number = ""
dig_number = number.to_s
repeater.times do
assembled_number = assembled_number + dig_number
end
return super_digit(super_digit(number) * repeater)
end



90 changes: 45 additions & 45 deletions test/fibonacci_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,54 +3,54 @@
describe "Fibonacci" do
it "will raise an error for n < 0" do
expect {
# Act
fibonacci(-1)
# Assert
}.must_raise ArgumentError
end

it "will return 0 for fib(0)" do
# Act
answer = fibonacci(0)

# Assert
expect(answer).must_equal 0
end

it "will return 1 for fib(1)" do
# Act
answer = fibonacci(1)

fibonacci(-1)
# Assert
expect(answer).must_equal 1
end

it "will return 1 for fib(2)" do
# Act
answer = fibonacci(2)

# Assert
expect(answer).must_equal 1
end
it "will return 3 for fib(4)" do
# Act
answer = fibonacci(4)
}.must_raise ArgumentError
end

# Assert
expect(answer).must_equal 3
end
it "will return 5 for fib(5)" do
# Act
answer = fibonacci(4)
it "will return 0 for fib(0)" do
# Act
answer = fibonacci(0)

# Assert
expect(answer).must_equal 0
end

# Assert
expect(answer).must_equal 3
end
it "will return 55 for fib(10)" do
# Act
answer = fibonacci(10)
it "will return 1 for fib(1)" do
# Act
answer = fibonacci(1)

# Assert
expect(answer).must_equal 1
end

# Assert
expect(answer).must_equal 55
end
it "will return 1 for fib(2)" do
# Act
answer = fibonacci(2)

# Assert
expect(answer).must_equal 1
end
it "will return 3 for fib(4)" do
# Act
answer = fibonacci(4)

# Assert
expect(answer).must_equal 3
end
it "will return 5 for fib(5)" do
# Act
answer = fibonacci(4)

# Assert
expect(answer).must_equal 3
end
it "will return 55 for fib(10)" do
# Act
answer = fibonacci(10)

# Assert
expect(answer).must_equal 55
end
end
38 changes: 19 additions & 19 deletions test/super_digit_test.rb
Original file line number Diff line number Diff line change
@@ -1,61 +1,61 @@
require_relative "test_helper"

xdescribe "super_digit" do
describe "super_digit" do
it "will return 2 for super_digit(9875)" do
# Act
answer = super_digit(9875)

# Assert
expect(answer).must_equal 2
end

it "will return 5 for super_digit(5)" do
# Act
answer = super_digit(5)

# Assert
expect(answer).must_equal 5
end

end
it "will return 6 for super_digit(123)" do
# Act
answer = super_digit(123)

# Assert
expect(answer).must_equal 6
end

it "will return 6 for super_digit(12327)" do
# Act
answer = super_digit(12327)

# Assert
expect(answer).must_equal 6
end

describe "refined superdigit" do
it "will return 1 for n = 1 and k = 1" do
# Act
answer = refined_super_digit(1, 1)

# Assert
expect(answer).must_equal 1
end

it "will return 8 for n=9875 and k = 4" do
# Act
answer = refined_super_digit(9875, 4)

# Assert
expect(answer).must_equal 8
end

it "will return 3 for n=148 and k = 3" do
# Act
answer = refined_super_digit(148, 3)

# Assert
expect(answer).must_equal 3
# Act
answer = refined_super_digit(148, 3)
# Assert
expect(answer).must_equal 3
end
end
end