Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaves - Mariya #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Leaves - Mariya #39

wants to merge 1 commit into from

Conversation

M-Burr
Copy link

@M-Burr M-Burr commented Dec 10, 2019

Linked List Comprehension Questions

Question Response
1. What advantages does a LinkedList have over an Array? Elements can be added to linked lists indefinitely & it is easier to remove elements from a linked list.
2. When is an Array more advantageous? When you want to retrieve elements by specific index numbers.

Copy link

@CheezItMan CheezItMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You definitely have a feel for linked lists, but you have a few bugs here. Take a look at my comments and let me know if you have questions.

@@ -10,36 +10,70 @@ def initialize
# Time complexity - ?
# Space complexity - ?
def add_first(data)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -10,36 +10,70 @@ def initialize
# Time complexity - ?
# Space complexity - ?
def add_first(data)

@head = Node.new(data, @head)
end

# Time complexity - ?
# Space complexity - ?
def get_first

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

until current.next.nil?
current = current.next
end
return current.data
end

# Time complexity - ?
# Space complexity - ?
def get_at_index(index)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about if the index is greater than the length of the list?

end

# Time complexity - ?
# Space complexity - ?
def get_last

current = @head

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if head is nil?

Suggested change
current = @head
return nil if @head.nil?
current = @head

count += 1
temp = temp.next
end
return count
end

# Time complexity - ?
# Space complexity - ?
def add_last(data)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

return nil
else
return @head.data
end
end

# Time complexity - ?
# Space complexity - ?
def length

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment on lines 10 to 11
# Time complexity - ?
# Space complexity - ?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing on any space/time complexity????

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants