Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yasmin- Leaves #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Yasmin- Leaves #30

wants to merge 1 commit into from

Conversation

YasminM11
Copy link

Linked List Comprehension Questions

Question Response
1. What advantages does a LinkedList have over an Array? In linked list each node can be located anywhere in memory, the list elements can be easily inserted or removed without reallocation.
2. When is an Array more advantageous? when we are looking for an element using index is much easier using a array.
3. When is an Array more advantageous?

@YasminM11 YasminM11 changed the title all tests passing Yasmin- Leaves Dec 9, 2019
CheezItMan
CheezItMan reviewed Dec 18, 2019
View reviewed changes
Copy link

@CheezItMan CheezItMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You definitely have a feel for linked lists, but you have a few bugs here. Take a look at my comments and let me know if you have questions.

lib/linked_list.rb
# Time complexity - ?
# Space complexity - ?
# Time complexity - o(1)
# Space complexity - o(1)
def add_first(data)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

lib/linked_list.rb
# Time complexity - ?
# Space complexity - ?
# Time complexity - o(1)
# Space complexity - o(1)
def get_first
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

lib/linked_list.rb
# Time complexity - ?
# Space complexity - ?
# Time complexity - o(n)
# Space complexity - o(1)
def length
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

lib/linked_list.rb

new_node = Node.new(data)
if @head.nil?
add_first(data)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good re-use of an existing method.

lib/linked_list.rb
# Time complexity - ?
# Space complexity - ?
# Time complexity - o(n)
# Space complexity - o(1)
def add_last(data)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

lib/linked_list.rb
def get_last

current = @head
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if head is nil?

Suggested change
current = @head
return nil if head.nil?
current = head

lib/linked_list.rb
# Time complexity - ?
# Space complexity - ?
# Time complexity - o(n)
# Space complexity - o(n)
def get_at_index(index)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if index is greater than the length of the list?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CheezItMan CheezItMan CheezItMan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YasminM11 @CheezItMan