Added longest prefix, needs work to pass test #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Sep 19, 2019
|
|
||
| while list.length >= i | ||
| if compare_to == list[i] | ||
| list.delete_at(list[i]) |
There was a problem hiding this comment.
delete_at takes an index number as an argument not an element. So that's why this isn't working.
delete_at also shifts each subsequent element over one index so it's an O(n) method. Since it's nested inside a loop which runs n times, this means the method would be O(n2)
Also if you delete an element you should decrement i by one so that you don't end up skipping any duplicates.
| def longest_prefix(strings) | ||
| raise NotImplementedError, "Not implemented yet" | ||
|
|
||
| common_word = "" |
There was a problem hiding this comment.
You are going to need 2 loops here one of which is looping through the characters inside one of the strings. You only have one loop here and you're comparing using an index for the array as an index for a letter in a word.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both my methods need work to pass...this is what I have so far.