-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Branches Vi && Steph #21
base: master
Are you sure you want to change the base?
Conversation
AdagramsWhat We're Looking For
Fantastic work on this project, you two! Your submission has really excellent and readable code. You two made really good decisions about how to keep the code clean and logical. There are even small touches like how you had the comments in the file to describe the methods that were really good. I have a few comments to point out places where your code could've been cleaned up a little-- this mostly is in some places where "dead code" remained. That being said, great work overall! :) |
end | ||
all_letters << letters | ||
end | ||
all_letters = all_letters.flatten |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NICE! This ends up being so clean and clever!
[],['A', 'E', 'I', 'O', 'U', 'L', 'N','R', 'S', 'T'], | ||
['D','G'],['B', 'C', 'M','P'],['F','H', 'V', 'W', 'Y'], | ||
['K'],[],[],['J', 'X'],[],['Q', 'Z'] | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clever data structure!
end | ||
end | ||
puts letter_points | ||
puts word.split("") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to delete your puts
statements before you submit!
|
||
# Wave 4 | ||
|
||
def highest_score_from(words) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here, you have a first definition of a method named highest_score_from
, and then below, you redefine a method with the same name. Ruby ends up using the later definition (because that's what gets defined last), but Ruby still gives a warning warning: method redefined; discarding old highest_score_from
. Feel free to delete this method if it doesn't get used in the end!
top_word = "" | ||
top_score = 0 | ||
tie_breaker_word = "" | ||
tie_breaker_score = "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable tie_breaker_score
ends up not being used anywhere else in the file-- is it safe to delete?
Adagrams
Congratulations! You're submitting your assignment.
Comprehension Questions
Enumerable
mixin? If so, where and why was it helpful?