Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sammi-Jo and Jackie's Webflix and Chill #14

Open
wants to merge 63 commits into
base: master
Choose a base branch
from

Conversation

jfahmy
Copy link

@jfahmy jfahmy commented Dec 21, 2018

Video Store Consumer

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Paste a link to the PR for your API Ada-C10/VideoStoreConsumer-API#15
For each person in your pair, describe something you learned from your partner during this project Jackie - You can always use a button the user clicks instead of trying to lift up state/ if you designed something not the best way you can make it seem intentional. Sammi-Jo - If a higher component is storing the needed state then the child can probably be functional.
What was one area of React you gained more clarity on during this assignment? All the CSS files get combined together into a single blob and will overwrite each other. SJ - ditto Jackie that the CSS files are just for organization, and to work around CSS class naming collisions, make CSS classes more specific to select the element you actually mean to select.
Describe how you solved the problem of having lists of movies that look mostly the same but have different content We gave the list names explicit variable names and they had their own components and functionality. In the website display they live on separate pages so we didn't have an issue.
Describe how you handled rentals with React The parent element stored "selectedCustomer" and "selectedMovie" as state and passed it to a child element called CheckOutForm.
Describe a DOM event your application handled Anytime we changed state, either related to a movie list or to create a checkout, this created a DOM event.
Did you use any functional stateless components? What for? Many of our lower-level components are functional because they are rendering a list item where the list will change in a higher-level class component. (For example, Customer and MovieCard.)
Did you use any container components? What for? Yes, many parent components (such as AppRouter, LibraryPage, and LibraryList) manage state containing lists of child components.
Do you have any recommendations on how we could improve this project for the next cohort? It was a good project, and we wish we didn't have so much senioritis. I guess if you emphasized how cool it is that this project ties together all these amazing things we now know how to do into our first full-stack project, I would have had slightly less senioritis. (When I think about it, I have personally made every part of the project, even stuff the instructors provided for us in the API back end.)

jfahmy and others added 30 commits December 17, 2018 13:54
…section on the SearchList page and executes a post request to the Rails API when clicked
…Library button, add relevant PropType validation, add images to Movie component
sjlee3157 and others added 30 commits December 18, 2018 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants