Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Katherine Fitzpatrick Trek #30

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

KatherineJF
Copy link

TREK

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What does it mean for code to be asynchronous? asynchronous is the opposite of synchronous so tasks aren't performed in a neatly sequential order.
Describe a piece of your code that executes asynchronously. How did this affect the way you structured it?
What kind of errors might the API give you? How did you choose to handle them?
Suppose you needed to routinely find a specific Trip in the list by it's ID field. Would it be advantageous to keep the list in order by the id field? Explain why or why not.

@dHelmgren
Copy link

TREK

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Could be better.
Comprehension questions Incomplete. :(
Functionality
Click a button to load and view a list of trips Yes
Click a trip to load and view trip details Yes
Fill out a form to reserve a spot Yes, but it doesn't clear the form or tell me I got my spot on the UI
Errors are reported to the user Not through the UI.
CSS is DRY and attractive, uses CSS Grid, flexbox, and/or Bootstrap CSS was in good shape, but PLEASE never style blue on top of red again. My poor eyeballs!
Under the Hood
Trip data is retrieved using from the API Yes
JavaScript is well-organized and easy to read Yes
HTML is semantic Pretty good.
Overall This project has a lot of good technical execution, but it's let down somewhat by the lack of error reporting. If the form isn't showing what went wrong, your users are going to be very confused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants