-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Naheed Edges Trek #26
base: master
Are you sure you want to change the base?
Conversation
TREKWhat We're Looking For
Good work on this project Naheed! Your code style overall is pretty cool; I like it a lot. You stumbled on a syntax error that made submitting the form produce an error. Because submitting the form had a syntax error, I also didn't see any reporting of status or error to the user (the functions That being said, everything else looked good!! |
button.on('click', () => { | ||
clickDetails(`${trip.id}`); | ||
}) | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You want to add in another })
here...
reportStatus(error); | ||
console.log(error); | ||
}); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And you want to remove the });
here... and then your syntax error is fixed!
TREK
Congratulations! You're submitting your assignment!
Comprehension Questions
Trip
in the list by it's ID field. Would it be advantageous to keep the list in order by the id field? Explain why or why not.