Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trek jessie #20

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

jessiezhang2017
Copy link

@jessiezhang2017 jessiezhang2017 commented Nov 26, 2018

TREK

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What does it mean for code to be asynchronous? Asynchronous means that you can do many things at once. With AJAX, that means you can still interact with a web page while waiting for a request/response. Your page won't freeze and with for the response to come back.
Describe a piece of your code that executes asynchronously. How did this affect the way you structured it? The function of listTripDetail is executed asynchronously. The codes first will send a get request to API to get the trip details for the selected trip. While the system was waiting for the return of the response from API, the codes keeps on executes the next coding lines, which will add forms for user to make reservations and for user to add new trips. because the code of add forms might executed earlier than retrieve the data from API, it make sense had a separate tag in html file
What kind of errors might the API give you? How did you choose to handle them? I got an error 400 bad request when I try to adda new trip , I checked my code to make sure the attributes names of the object data I need to post is the same as the API required, and fixed the error.
Suppose you needed to routinely find a specific Trip in the list by it's ID field. Would it be advantageous to keep the list in order by the id field? Explain why or why not. if you in the question means user, the answer is yes. It will be advantageous to keep the list in order by the id field, since in that way, that trip will be always in the same position in the list, easy to be find. Otherwise, if the trip is list in the order by name etc, after other users add new trips, the trip list will be changed, the trip you are interested will change position, so make it hard to be find . if you in the question means programer, then the programer can code to find the trip by trip id , how the trips are listed will not impact.

@dHelmgren
Copy link

TREK

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Just two commits? :'(
Comprehension questions Good
Functionality
Click a button to load and view a list of trips Yes
Click a trip to load and view trip details Yes
Fill out a form to reserve a spot Yes
Errors are reported to the user Yes
CSS is DRY and attractive, uses CSS Grid, flexbox, and/or Bootstrap Yes
Under the Hood
Trip data is retrieved using from the API Yes
JavaScript is well-organized and easy to read Yes
HTML is semantic Yes
Overall Excellent job overall! This code is for the most part well-organized and easy to read, and it's clear the learning goals of this assignment were met. I especially appreciate the care you put into error handling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants