LIndsay - edges - reverse words #25

elle-terch · 2018-09-19T02:14:46Z

No description provided.

shrutivanw · 2018-11-15T00:40:51Z

lib/reverse_words.rb

+
+  end
+
+  return my_words


Since you're manipulating the string in-place, you don't need to return nil or my_words. Line 33 could simply be return.

shrutivanw · 2018-11-15T00:54:18Z

lib/reverse_words.rb

+      end
+    end
+
+    my_words = reverse(my_words, first_index, last_index)


Since you're manipulating the string in place, you don't need to assign the return value of reverse to my_words.

shrutivanw · 2018-11-15T00:58:03Z

Looks good!

I added some minor comments inline. Couple more notes:

Although your algorithm does work for the last test case " evol ", the algorithm does not explicitly handle multiple, consecutive white spaces. Can you think of how to add explicit consideration for the same?
I didn't see any description or comments on the time and space complexity. Slack me if you have any questions about it.

created algorithm that passed all test cases

825e7e3

shrutivanw reviewed Nov 15, 2018

View reviewed changes

Provide feedback