Laura | Nodes #33
Open
Laura | Nodes #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrutivanw
reviewed
Nov 20, 2018
| i = 0 | ||
| s = 0 | ||
| e = 0 | ||
|
|
There was a problem hiding this comment.
Minor: your indentation seems a little off.
shrutivanw
reviewed
Nov 20, 2018
| @@ -1,4 +1,46 @@ | |||
| # A method to reverse the words in a sentence, in place. | |||
| # A method to reverse the my_sentences in a sentence, in place. | |||
| # Time: O(n^2) | |||
There was a problem hiding this comment.
The time complexity of your algorithm is actually O(n). Take a read on an explanation on: https://github.com/Ada-C10/reverse_sentence/blob/solution/lib/reverse_sentence.rb
I'd also encourage you to elaborate your time and space complexity reasoning. Often, being able to explain your logic and reasoning is more important than getting the correct final answer.
|
Looks good! See comments inline about time and space complexity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time and Space complexity in comments of my code