Naheed Edges reverse_sentence #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrutivanw
reviewed
Nov 15, 2018
| if my_sentence == nil || my_sentence.length == 1 || my_sentence.length == 0 | ||
| return my_sentence | ||
| end | ||
| my_sentence = reverse_words(my_sentence) |
There was a problem hiding this comment.
Since reverse_words is doing all the string manipulations in-place and so is string_reverse, you don't need to return anything from those methods or assign them in this method.
Lines 8 and 9 can simply be:
reverse_words(my_sentence)
string_reverse(my_sentence, 0, (my_sentence.length - 1))
shrutivanw
reviewed
Nov 15, 2018
| # binding.pry | ||
| my_sentence = string_reverse(my_sentence, 0, (my_sentence.length - 1)) | ||
| # binding.pry | ||
| return my_sentence |
There was a problem hiding this comment.
Since all the string manipulations are being done in-place, lines 6 and 12 can simply be return
|
Nice work! I added some minor comments inline. I didn't see explanations on the time and space complexities. Take a read on https://github.com/Ada-C10/reverse_sentence/blob/solution/lib/reverse_sentence.rb and let me know if you have any questions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.