Amanda Ungco- Reverse Sentence #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amandaungco
changed the title
shrutivanw
reviewed
Nov 16, 2018
| end | ||
| return nil | ||
| end | ||
|
|
||
| def reverse_words(my_words) |
There was a problem hiding this comment.
Same comments as I added to the reverse_words' assignment.
shrutivanw
reviewed
Nov 16, 2018
| @@ -4,22 +4,6 @@ def reverse_sentence(my_sentence) | |||
| return reverse_words(reversed_string) | |||
There was a problem hiding this comment.
Since the string_reverse reverses the input string in place, you don't need to return anything or assign anything. reverse_sentence could simply be:
string_reverse(my_sentence)
reverse_words(my_sentence)
return
|
Looks good! I added some minor comments. I didn't see any explanation of the time and space complexities. Slack me if you'd like to soundboard your explanations or have any questions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The space complexity for my solution is constant, regardless of the size of the string, the same number of variables are created.
The time complexity of my solution is linear. Each of my helper methods is O(n).