Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STHOMAS_C10 Nodes #41

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

STHOMAS_C10 Nodes #41

wants to merge 2 commits into from

Conversation

Sabineth17
Copy link

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? Yes, I did have a few issues and continue to work on them. The HTML Validator let me know to add missing tags and utilize and additional tag in my header.
Why is it important to consider and use semantic HTML? It is important to consider and use semantics for HTML to keep the files DRY but also to have correspondingly clear and DRY stylesheets. I imagine that this would be equally important once we start interacting with JavaScript.
How did you decide to structure your CSS? I utilize multiple classes and ids to ensure that my files were appropriately communicating with my CSS files.
What was the most challenging piece of this assignment? Tracking and updating each file separately and organize my CSS stylesheet to connect with a specific file class/id.
Describe one area that you gained more clarity on when completing this assignment The linkage between CSS and html files. Better understanding of the FlexBox and CSS Grid application with CSS.
Optional
Did you deploy to GitHub Pages? If so, what is the URL to your website? I absolutely would like to deploy when I have richer materials. Is it OK to resubmit another pull request when I deploy?
Overall Great exercise. I am looking forward to practicing and applying the information.

@Sabineth17 Sabineth17 changed the title Finalizing pages and running HTML Validator STHOMAS_C10 Nodes Sep 18, 2018
@CheezItMan
Copy link

Personal Portfolio Site

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage Only 3 commits, good commit messages
Answered comprehension questions We use semantic tags to convey meaning of the content inclosed in a section or article or main etc element. I'm glad you found the exercise useful.
Page fully loads Check
No broken links (regular or images) Check
Includes at least 4 pages and styling Check
HTML
Uses the high-level tags for organization: header, footer, main In some of your pages, you have a lot of div elements. Instead I would suggest you use semantic tags instead.
Appropriately using semantic tags: section, article, etc. In some pages you are using some semantic tags, in others you do not.
All images include alternate text Almost
CSS
Using class and ID names in style declarations You are using classes quite a bit and appropriately. Nice work.
Style declarations are DRY Relatively DRY
Overall Nice work, you hit all the learning goals for the project. The site looks nice and colorful. The layout is a bit inconsistent between index.html and the blog and portfolio's page, but otherwise it looks great.


<body>

<div class="header">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of using div elements it's preferred to use semantic tags like in this case header.

<p> <h3>"Engineer Me"</h3></p>
</div>

<div class="topnav">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would use the nav element instead.

<p> <h3>"Favorite Art Portfolio"</h3></p>

</header>
<nav class="nav">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good use of semantic tags here!

}

/* Responsive layout - when the screen is less than 800px wide, make the two columns stack on top of each other instead of next to each other */
@media screen and (max-width: 800px) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Media Query!

<h3>Starting at ADA</h3>
<!-- <div> -->
<class="Ada">
<img src= "/Users/ada/Documents/HTML_CSS/personal-portfolio-site/images/Ada Developers Academy_files/program.png"/>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no alt attribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants