Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LJ - node #30

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

LJ - node #30

wants to merge 5 commits into from

Conversation

elle-johnnie
Copy link

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? Some of my links were missing attribute tags. I also apparently misused section tags b/c I didn't contain any header content within them. So I'll do some tag renaming to address all of those.
Why is it important to consider and use semantic HTML? It makes it much easier to distinguish elements and implement selectors in css.
How did you decide to structure your CSS? Each page has its own stylesheet and combines grid and flex layouts
What was the most challenging piece of this assignment? Aligning all the things.
Describe one area that you gained more clarity on when completing this assignment I feel like I got better at grabbing the right selectors when wanting to move things. I still struggle though with moving certain footer elements down to the bottom of a page even when I assign them to a grid space. One page it works perfect and rest don't even though the tags and syntax are seemingly the same...yet to figure it out though.
Optional
Did you deploy to GitHub Pages? If so, what is the URL to your website? Not yet.
Overall

@CheezItMan
Copy link

Personal Portfolio Site

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage More commits would be better, but the commit messages are good.
Answered comprehension questions Check, I'm glad you got more comfortable with using CSS selectors.
Page fully loads Check
No broken links (regular or images) Check
Includes at least 4 pages and styling Check, although most of the pages are empty.
HTML
Uses the high-level tags for organization: header, footer, main Check
Appropriately using semantic tags: section, article, etc. Check, good use of semantic tags, however as you noted the section tags don't have headers as the 1st lines.
All images include alternate text Check
CSS
Using class and ID names in style declarations Effective use of classes and ids
Style declarations are DRY You are repeating some styling rules
Overall Nicely done. You have the pages up and managed all the learning goals. Good work.

CheezItMan
CheezItMan reviewed Sep 21, 2018
View reviewed changes
code-journal.html
<p>Churning produces small butter grains floating in the water-based portion of the cream. This watery liquid is called buttermilk—although the buttermilk most common today is instead a directly fermented skimmed milk. The buttermilk is drained off; sometimes more buttermilk is removed by rinsing the grains with water. Then the grains are "worked": pressed and kneaded together. When prepared manually, this is done using wooden boards called scotch hands. This consolidates the butter into a solid mass and breaks up embedded pockets of buttermilk or water into tiny droplets.</p>
<p>Commercial butter is about 80% butterfat and 15% water; traditionally made butter may have as little as 65% fat and 30% water. Butterfat is a mixture of triglyceride, a triester derived from glycerol and three of any of several fatty acid groups. Butter becomes rancid when these chains break down into smaller components, like butyric acid and diacetyl. The density of butter is 0.911 g/cm3 (0.527 oz/in3), about the same as ice.</p>
</article>
<main>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty main element

.gitignore
@@ -1 +1 @@
.DS_Store
.idea
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should leave .DS_Store in this file.

stylesheets/style.css
align-self: center;
}
/*color pallette*/
.these-colors{
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These don't seem to be used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CheezItMan CheezItMan CheezItMan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elle-johnnie @CheezItMan