Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Val - Edges - Personal Portfolio Site #26

Open
wants to merge 33 commits into
base: master
Choose a base branch
from

Conversation

valgidzi
Copy link

@valgidzi valgidzi commented Sep 17, 2018

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? The HTML Validator warned me that I had two h1 tags, but I decided to keep both.
Why is it important to consider and use semantic HTML? Using semantic HTML makes using CSS easier and helps screen readers provide better information.
How did you decide to structure your CSS? There is one main stylesheet that has all styles for the main page and is a basic template for all other pages. All other pages have their own additional stylesheet.
What was the most challenging piece of this assignment? Deciding on a layout and sticking to it was the most challenging piece of this assignment.
Describe one area that you gained more clarity on when completing this assignment I gained more clarity on using Flexbox to position elements on the page, for example, getting the footer to stick to the bottom of the page.
Optional
Did you deploy to GitHub Pages? If so, what is the URL to your website?
Overall

@droberts-sea
Copy link

Personal Portfolio Site

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage yes
Answered comprehension questions yes
Page fully loads yes
No broken links (regular or images) yes
Includes at least 4 pages and styling yes
HTML
Uses the high-level tags for organization: header, footer, main yes
Appropriately using semantic tags: section, article, etc. yes
All images include alternate text yes
CSS
Using class and ID names in style declarations yes
Style declarations are DRY yes
Overall

Good work overall! It's clear to me that the learning goals for this assignment were met.

For this project, the instructors are giving a spot-check review, looking for big patterns rather than going through your code line-by-line. If you’d like a more in-depth review, please reach out to your instructor!

</header>
<section class="main">
<h1>Blog</h1>
<article>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why <section class="main"> and not <main>?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants