Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shelan's portfolio #21

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions about.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
<!DOCTYPE html>
<html>
<head>
<meta charset="utf-8">
<title>About</title>
<link href="normalize.css" rel="stylesheet">
<link href="styles/about.css" rel="stylesheet">
</head>
<body>

<section class="header">
<li><a href="portfolio.html">portfolio.</a></li>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

li elements must be children of ul or ol elements.

<li><a href="blog.html">blog.</a></li>
<li><a href="index(port).html">home.</a></li>
<li><a href="contact.html">contact.</a></li>
</section>

<div class="background">
<div class="info">
<h1>About Me</h1>
<div class="meta">
<a href="https://i.imgur.com/AAfOSPx.jpg" target="_b" class="author"></a><br>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

target="_b" isn't valid. You probably meant: target="_blank"

</div>
</div>
</div>

<section class="content">
<p>Lorem ipsum dolor sit amet, consectetur adipiscing elit. In nisl turpis, porttitor et finibus id, viverra a metus. Praesent non ante sed orci posuere varius quis sit amet dui. Cras molestie magna orci, id gravida dolor molestie in. Duis sollicitudin turpis quis tortor egestas, ut ultrices nisl elementum. Vestibulum sed ipsum eget nulla laoreet cursus in ac sem. Integer a suscipit justo, quis aliquam sapien. Maecenas et tellus nibh. Vivamus tincidunt eros id commodo pellentesque. porttitor et finibus id, viverra a metus. Praesent non ante sed orci posuere varius quis sit amet dui. Cras molestie magna orci, id gravida dolor molestie in. Duis sollicitudin turpis quis tortor egestas, ut ultrices nisl ele</p>
<!-- <p align="center"><a href="https://twitter.com/nodws" class="btn twtr" target="_b">Follow me on Twitter</a>
</p> -->
</section>
<!--- Footer -------------->
<footer>
<ul class="footer">
<li>© 2018-</li>
<li>contact information: [email protected] <a href="[email protected]"</li>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The anchor tag isn't closed, and it should read like:

<li>contact information: <a href="[email protected]"> [email protected] </a></li>

</ul>
</footer>
</body>
</html>
37 changes: 37 additions & 0 deletions blog.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
<!DOCTYPE html>
<html>
<head>
<meta charset="utf-8">
<title>Blog</title>
<link href="normalize.css" rel="stylesheet">
<link href="styles/blog.css" rel="stylesheet">
</head>
<body class="container">
<section class="header">
<li><a href="index(port).html">home.</a></li>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also li can't be a child of section, it can only be a child element of ul or ol.

<li><a href="portfolio.html">portfolio.</a></li>
<li><a href="about.html">about me.</a></li>
<li><a href="contact.html">contact.</a></li>
</section>

<section class="title">
<h1>Blog Posts<h1>
</section>


<section class="blogs">
<a href="blog_posts.html">
<img src="https://i.imgur.com/WVECL14.jpg" alt="blogpost" /></a>
</section>


<!--- Footer -------------->
<footer>
<ul class="footer">
<li>© 2018-</li>
<li>contact information: [email protected] <a href="[email protected]"</li>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your anchor tag isn't correct this should read like:

<li>contact information: <a href="[email protected]"> [email protected] </a></li>

</ul>
</footer>
</body>
</head>
</html>
21 changes: 21 additions & 0 deletions blog_posts.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
<section class="blogs">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: This file isn't valid HTML.

<blockquote class="blog_one">
<h1>Why coding is awesome!</h1>
Nemo enim ipsam voluptatem quia voluptas sit aspernatur aut odit aut fugit, sed quia consequuntur magni dolores eos qui ratione voluptatem sequi nesciunt.Now we'll fluff it. Do a cabin-ectomy. There's some little stringy ones that live down here. There's nothing worse than an angry tree. I think you'll be tickled with what you can do with something that starts out looking this bad.
</blockquote>

<blockquote class="blog_two">
<h1>Ruby 101</h1>
Nemo enim ipsam voluptatem quia voluptas sit aspernatur aut odit aut fugit, sed quia consequuntur magni dolores eos qui ratione voluptatem sequi nesciunt.Now we'll fluff it. Do a cabin-ectomy. There's some little stringy ones that live down here. There's nothing worse than an angry tree. I think you'll be tickled with what you can do with something that starts out looking this bad.
</blockquote>

<blockquote class="blog_three">
<h1>Studying tips</h1>
Nemo enim ipsam voluptatem quia voluptas sit aspernatur aut odit aut fugit, sed quia consequuntur magni dolores eos qui ratione voluptatem sequi nesciunt.Now we'll fluff it. Do a cabin-ectomy. There's some little stringy ones that live down here. There's nothing worse than an angry tree. I think you'll be tickled with what you can do with something that starts out looking this bad.
</blockquote>

<blockquote class="blog_four">
<h1>Eye exercises</h1>
Nemo enim ipsam voluptatem quia voluptas sit aspernatur aut odit aut fugit, sed quia consequuntur magni dolores eos qui ratione voluptatem sequi nesciunt. Now we'll fluff it. Do a cabin-ectomy. There's some little stringy ones that live down here. There's nothing worse than an angry tree. I think you'll be tickled with what you can do with something that starts out looking this bad.
</blockquote>
</section>
41 changes: 41 additions & 0 deletions contact.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
<!DOCTYPE html>
<html>
<head>
<meta charset="utf-8">
<title>Contact</title>
<link href="normalize.css" rel="stylesheet">
<link href="styles/contact.css" rel="stylesheet">
</head>
<body>
<section class="header">
<li><a href="portfolio.html">portfolio.</a></li>
<li><a href="index(port).html">home.</a></li>
<li><a href="blog.html">blog.</a></li>
<li><a href="about.html">about me.</a></li>
</section>
<h1>Contact Information</h1>
<!-- An Unordered List with List Items -->
<nav>
<ul class="contact">
<li>Twitter: <a href="https://twitter.com/shelandebesai">Shelan's Twitter Page</a>
<img src="https://i.imgur.com/3zYA5x0.png" alt="twitter"/>
</li>
<li>Github: <a href="https://github.com/sheland/"> Shelan's Github</a>
<img src="https://i.imgur.com/GT4QCa1.png" alt="github"/>
</li>
<li>Email: <a href="[email protected]/"></a>
<a href="mailto:[email protected]">Shelan's Email</a>
<img src="https://i.imgur.com/KGQdvsr.png" alt="email"/>
</li>
</ul>
</nav>
<!--- Footer -------------->
<footer>
<ul class="footer">
<li>© 2018-</li>
<li>contact information: [email protected] <a href="[email protected]">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This li element isn't closed.

Also the a element isn't closed

</ul>
</footer>
</body>
</head>
</html>
Binary file added images/background_bottom_plants.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/background_bricks.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/background_plant_right.jpeg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/background_retro.jpeg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/background_waterpaint.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/books.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/email.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/github.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/glasses.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/sitting.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/standing.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/twitter.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
33 changes: 33 additions & 0 deletions index(port).html
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
<!DOCTYPE html>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you export this file from a 3rd party program? Why is (port) in the filename.

<html>
<head>
<meta charset="utf-8">
<title>Home</title>
<link href="normalize.css" rel="stylesheet">
<link href="styles/styles(port).css" rel="stylesheet">
</head>
<body class="container">

<section class="header">
<li><a href="portfolio.html">portfolio.</a></li>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also li can't be a child of section, it can only be a child element of ul or ol.

<li><a href="blog.html">blog.</a></li>
<li><a href="about.html">about me.</a></li>
<li><a href="contact.html">contact.</a></li>
</section>

<!-- Welcome message -->
<section class="greeting">
<h1 class="first_greet">Shelan's Portfolio</h1>
<h1 class="second_greet">Student at Ada Developer's Academy</h1>
<h1 class="third_greet">Seattle Native</h1>
</section>
<!--- Footer -------------->
<footer>
<ul class="footer">
<li>© 2018-</li>
<li>contact information: [email protected] <a href="[email protected]">
</ul>
</footer>
</body>
</head>
</html>
60 changes: 60 additions & 0 deletions portfolio.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
<!DOCTYPE html>
<html>
<head>
<meta charset="utf-8">
<title>Portfolio</title>
<link href="normalize.css" rel="stylesheet">
<link href="styles/portfolio.css" rel="stylesheet">
</head>
<body class="container">
<section class="header">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of using a class header I would suggest using the header tag.

<li><a href="portfolio.html">portfolio.</a></li>
<li><a href="index(port).html">home.</a></li>
<li><a href="blog.html">blog.</a></li>
<li><a href="about.html">about me.</a></li>
<li><a href="contact.html">contact.</a></li>
</section>

<section class="title">
<h1>Projects</h1>
</section>

<!-- Section of listed projects -->
<section class="projects">
<ul class="project_blog">
<li class="project">
<a href="https://github.com/sheland/oo-ride-share">
<img src="https://i.imgur.com/KCzNwqf.jpg)" alt="Bicycle" />
</a>
<span>Project Ride Share</span>
</li>
<li class="project">
<a href="https://github.com/sheland/grocery-store">
<img src="https://i.imgur.com/oWffCPW.png" alt="Grocery Store" />
</a>
<span>Project Grocery Store</span>
</li>
<li class="project">
<a href="https://github.com/sheland/adagrams">
<img src="https://i.imgur.com/LgzHHYr.png" alt="Game" />
</a>
<span>Project Adagrams</span>
</li>
<li class="project">
<a href="https://github.com/sheland/Solar-System">
<img src="https://i.imgur.com/98scHyo.jpg" alt="Solar System" />
</a>
<span>Project Solar System</span>
</li>
</ul>
</section>
<!--- Footer -------------->
<footer>
<ul class="footer">
<li>© 2018-</li>
<li>contact information: [email protected] <a href="[email protected] ">
</ul>
</footer>
</body>
</head>
</html>
84 changes: 84 additions & 0 deletions styles/about.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,84 @@
@import url('https://fonts.googleapis.com/css?family=Josefin+Sans:400,400i,600,600i');
html,body{
margin:0;
height:120%;
font-family: 'Josefin Sans', sans-serif;

}

.header {
display: flex;
list-style-type: none;
justify-content: flex-end;
font-size: 2em;
}
.background{
position:relative;
overflow:hidden;
display:flex;
flex-wrap: wrap;
justify-content: center;
align-items: flex-start;
align-content: flex-start;
height:50vw;
min-height:400px;
max-height:550px;
min-width:300px;
color:#eee;
}

.background:before{

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice parallax effect.

content:"";
width:100%;
height:100%;
position:absolute;
top:0;
left:0;
-webkit-backface-visibility: hidden;
-webkit-transform: translateZ(0) scale(1.0, 1.0);
transform: translateZ(0);
background:#1B2030 url(https://i.imgur.com/MEyQpKv.jpg) top center no-repeat;
background-size:cover;
background-attachment:fixed;
animation: grow 60s linear 10ms infinite;
transition:all 0.2s ease-in-out;
z-index:-2
}

.sides, .info{
flex: 0 0 auto;
width:50%
}
.info{
width:100%;
padding:15% 10% 0 10%;
text-align:center;
text-shadow:0 2px 3px rgba(0,0,0,0.2)
}
.author{
display:inline-block;
width:80px;
height:80px;
border-radius:90%;
background:url(https://i.imgur.com/AAfOSPx.jpg) center no-repeat;
background-size:cover;
box-shadow:0 2px 3px rgba(0,0,0,0.3);
margin-bottom:5px
}

@keyframes grow{
0% { transform:scale(1)}
50% { transform:scale(1.2)}
}
.content{
padding:5% 10%;
text-align:justify
}

.footer {
display: flex;
justify-content: center;
padding-top: 50px;
list-style-type: none;
font-size: 1em;
}
49 changes: 49 additions & 0 deletions styles/blog.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
@import url('https://fonts.googleapis.com/css?family=Josefin+Sans:400,400i,600,600i');
html, body {
width: 100%;
height: 100%;
font-family: 'Josefin Sans', sans-serif;
}

body {
background-image: url("https://i.imgur.com/LSpa1mM.jpg");
}

.container {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notice you have the this style repeated in multiple files. Not exactly DRY.

display: grid;
grid-template-rows: 1fr 1fr 4fr 1fr
}

.header {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also have a lot of these styles repeated in multiple files

display: flex;
list-style-type: none;
margin-left: auto;
font-size: 2em;
}

.title {
display: flex;
flex-direction: row;
justify-content: center;
font-size: 30px;
padding-top: 20px;
}

.blogs img {
width: 500px;
height: 500px;
border-radius: 70%;
margin-left: 300px;
padding-bottom: 20px;
display: wrap;

}


.footer {
display: flex;
justify-content: center;
padding-top: 50px;
list-style-type: none;
font-size: 1em;
}
Loading