sam jo's palindrome check (nodes) #24
Conversation
| return false | ||
| end | ||
|
|
||
| stripped_phrase = "" |
There was a problem hiding this comment.
Creating a new string, i.e. stripped_phrase will increase the time complexity. Can you think of an algorithm that does not need this additional copy of the string and can skip white spaces as it examines them?
| @@ -1,5 +1,31 @@ | |||
| # A method to check if the input string is a palindrome. | |||
| # Return true if the string is a palindrome. Return false otherwise. | |||
| def palindrome_check(my_phrase) | |||
There was a problem hiding this comment.
I didn't see any comments on the time and space complexity of your algorithm. Can you think through it and explain it?
Gentle reminder: Always explain what n stands for while explaining your time and space complexity. That along with your explanation for reasoning behind your answer, is the complete answer for the time and space complexity.
|
Nice job working on the algorithm. See comments inline for further thinking and for explaining the time and space complexity of your algorithm. Also take a look at an alternative algorithm on: https://github.com/Ada-C10/palindrome_check/blob/solution/lib/palindrome_check.rb |
No description provided.