Jackie's Palindrome check #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrutivanw
reviewed
Nov 20, 2018
| @@ -1,5 +1,26 @@ | |||
| # A method to check if the input string is a palindrome. | |||
| # Return true if the string is a palindrome. Return false otherwise. | |||
|
|
|||
| #The space complexity is O(1) because no space is alocated to create a new object | |||
| #The time complexity is O(n) because the while loop needs to walk through each item in the string n times | |||
There was a problem hiding this comment.
Always explain what n stands for while explaining your time and space complexity. In this case, n is the number of characters in the input string or the length of the input string.
shrutivanw
reviewed
Nov 20, 2018
| i = 0 | ||
| j = my_phrase.length - 1 | ||
| while i < j | ||
| until my_phrase[i] != " " |
There was a problem hiding this comment.
Also continue to check that i is less than j. test case: input string with all white spaces.
shrutivanw
reviewed
Nov 20, 2018
| until my_phrase[i] != " " | ||
| i += 1 | ||
| end | ||
| until my_phrase[j] != " " |
There was a problem hiding this comment.
also continue to check that j is greater than i
|
Nice work with the algorithm and with explaining the time and space complexity. I added some fit-n-finish comments inline. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.