check matrix sum #16
Open
check matrix sum #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrutivanw
reviewed
Nov 26, 2018
| # return true (iterated through entire matrix with corresponding rows and columns equal to eachother) | ||
|
|
||
| end | ||
| return true | ||
| raise NotImplementedError |
There was a problem hiding this comment.
Line 36 is dead code and should be safely deleted.
|
Nice work! Minor: explain what n stands while explaining your time or space complexities in terms of n. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time complexity: O(n^2), assuming the matrix to check is always a square. We must iterate through each value in the matrix to sum the row and sum the column.
Space complexity: O(1), no extra memory is needed since we are only using 2 variables to keep track of the row_sum and column_sum per given iteration of the loop.