Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pushpa_Agr_matrix_check_sum #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

pushpaagr
Copy link

Space complexity O(1) constant, variable will be unchanged despite how long the matrix is.

Time complexity is n^2 as I have a loop within a loop.

j = 0
i = 0

length.times do

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could consider combining this and the next loop like so:

   length.times do
      sum_row += matrix[k][i] 
      sum_column += matrix[i][k]
      i += 1
   end

@shrutivanw
Copy link

Nice work! One minor comment added inline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants