Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amanda #47

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Amanda #47

wants to merge 2 commits into from

Conversation

amandaungco
Copy link

Litter Patrol

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
How are events / event handlers and this.state connected?
What are two ways to do "dynamic styling" with React? When should they be used?
Much like Rails works with the HTTP request->response cycle, React works with the browser's input->output cycle. Describe React's cycle from receiving user input to outputting different page content.
Compare how React and Rails' views differ. Given different circumstances, these systems have different goals. How does this impact on their design and how we are supposed to use them?
What was a challenge you were able to overcome on this assignment?

CS Fundamentals Questions

Question Answer
Consider the code on the first few lines of App.render (it starts with this.state.items.map). What is the Big-O time complexity of this code, where n is the number of active game items?
What part of React might benefit most from the use of specific data structure and algorithms?
Consider what happens when React processes a state change from setState -- it must re-render all of the components that now have different content because of that change.
What kind of data structure are the components in, and what sort of algorithms would be appropriate for React's code to "traverse" those components?
Speculate wildly about what the Big-O time complexity of that code might be.

@dHelmgren
Copy link

Litter Patrol

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene 2 commits.
Comprehension questions Blank
Functionality
Clicking on litter or nature shows a check or X respectively Yes
Clicking on litter appropriately updates the score No score updates.
Under the Hood
JavaScript is well-organized and easy to read Yes
Functions are named appropriately Yes
Callback functions are passed to components appropriately Close! You gave a wrong name, otherwise the project would be working perfectly!
Overall This was super close, and it looks like you have the pattern for passing methods down to components in hand, if not perfect yet.

const items = this.state.items.map((item, i) => {
return <GameItem
height={item.height} // Height - used for a CSS style to position on the screen
layer={100 + i} // Layer - used for a CSS style to show items on-top of bg
key={item.id} // Key - to help React with performance
onItemClick = {this.onClickHandler}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, your naming convention is wrong here, keeping your click handler from being passed down. this.onClickHandler doesn't exist. This is where we pass the function down to the component, so we want to use this.onItemClick instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants