hotel.rb #24

kayxn23 · 2018-09-10T07:56:38Z

Hotel

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Describe a design decision you had to make when working on this project. What options were you considering? What helped you make your final decision?	In the beginning I had to decide if certain behaviors should belong to either Room, Reservation or TrackingSystem classes. I considered creating more behaviors in the Reservation class, but eventually decided to write them in the TS class to so that I could centralize all the behaviors, and because it makes more sense for a TrackingSystem to have behaviors than Room and Reservation objects in real life.
Describe a concept that you gained more clarity on as you worked on this assignment.	I gained more clarity on composition by trial and error. I realize more how mapping out has-a and is-a relationships prior to coding is crucial part of the design process, because each object needs to work together and ideally be flexible for change. Also, I learned that it's difficult to decipher User Stories, and I need to ask more clarification questions around this.
Describe a nominal test that you wrote for this assignment.	Making sure that the methods throw errors if an invalid argument is entered is in most of my tests.
Describe an edge case test that you wrote for this assignment.	Making sure that an argument error is raised if a start_date is after an end_date input.
How do you feel you did in writing pseudocode first, then writing the tests and then the code?	I was able to follow this procedure more than half of the time writing this program. Writing pseudocode comes more naturally than writing tests, but I think this project has made me more comfortable than before with driving my code with Tests. It's difficult to write tests for a method that is more complex and when I'm not sure how it's going to look yet. Writing tests did help guide my code, but I kept getting drawn into writing the code methods when errors came up. I need more practice coming up with edge cases.

… classes

…servatoin method in TrackingSystem class, tests passing but still need to refactor for more reasonable usability

@Reservations

…eturn value to the @Reservations list

…refactoring this code and creating helper methods"

…ultiple rooms in one reservation

…e attribute

…ssertions, 2 failures(failures surrounding create reservation )

…ake_reservation method

…lects the room number that is reserved

…o tests, all tests passing

…. now the method returns an array of available rooms

…failing, need to increase coverage

…ent error is raised appropriately

… unnecessary comments

… rather than Array. Each reservation just stores one room

…his method as well

…ing as expected

…_num: was num:

… commented out code blocks in TrackingSystem to see if I'll call on that method from TS later

…pdate tests

…are 3 tests for this method, all tests passing

…% coverage

…on method

… that are already in a block

…all rooms were available

…n TrackingSystem class should be !=

…'t recognize id as a Symbol

CheezItMan · 2018-09-17T03:14:28Z

Hotel

What We're Looking For

Feature	Feedback
Baseline
Used git regularly	Good number of commits and good commit messages
Answer comprehension questions	Check, I hope you see now that you probably should have broken out some functionality into `Reservation` and `Block`
Design
Each class is responsible for a single piece of the program	You have `TrackingSystem` doing too much. Pretty much all your code is going there and `Reservation` and `Block` are pretty much just structs.
Classes are loosely coupled	Yes
Wave 1
List rooms	Check
Reserve a room for a given date range	Check
List reservations for a given date	Check
Calculate reservation price	Check
Invalid date range produces an error	Check, but that check should go in `Block` and `Reservation`
Test coverage	99%
Wave 2
View available rooms for a given date range	Check
Reserving a room that is not available produces an error	Check
Wave 3
Create a block of rooms	Check
Check if a block has rooms	Check
Reserve a room from a block	Check
Fundamentals
Names variables, classes and modules appropriately	Check
Understanding of variable scope - local vs instance	Check
Can create complex logical structures utilizing variables	Check
Appropriately uses methods to break down tasks into smaller simpler tasks	Your methods could use some breaking down and your classes are too centralized.
Understands the differences between class and instance methods	Check
Appropriately uses iterators and enumerables	You mostly just used `.each`.
Appropriately writes and utilizes classes	Like I've said you centralized too much in `TrackingSystem`.
Appropriately utilizes modules as a mechanism to encapsulate functionality	No modules
Wrap Up
There is a refactors.txt file	Check
The file provides a roadmap to future changes	Check
Additional Feedback	Nice work. You hit all the learning goals. I do think your design is a bit awkward as too much is done in `TrackingSystem`, but it all works. I also left some small comments in your testing. Overall outstanding work.

CheezItMan · 2018-09-17T02:45:22Z

lib/reservation.rb

+class Reservation
+  attr_reader :room_num, :start_time, :end_time, :price
+
+  def initialize(attributes)


you should have some checks to make sure the start and end dates are correct here.

CheezItMan · 2018-09-17T02:46:34Z

lib/reservation.rb

+    total_cost = 0
+    return total_cost = ((end_time - start_time) * price).round(2)
+  end
+


I would suggest to add methods to tell if two reservations clash, or if a reservation is on a specific date.

CheezItMan · 2018-09-17T02:47:11Z

lib/tracking_system.rb

+require_relative 'block'
+require 'pry'
+
+NUMBER_OF_ROOMS = 20


good use of constants!

CheezItMan · 2018-09-17T02:50:14Z

lib/tracking_system.rb

+    raise ArgumentError.new"#{date} must be instance of Date" unless date.instance_of? Date
+    all_reservations = []
+    @reservations.each do |reservation|
+      if (reservation.start_time...reservation.end_time).include?(date)


It would make a great deal of sense to have a method in Reservation to tell if the reservation occurs on the given date. That way the tracking system doesn't need to involve itself in the internal details of a reservation.

CheezItMan · 2018-09-17T02:53:15Z

lib/tracking_system.rb

+        available_rooms << room
+      else
+        room.reserved_dates.each do |dates_hash|
+          if ranges_overlap?((dates_hash[:start_time]...dates_hash[:end_time]).to_a, (start_time..end_time).to_a) == false && room.block == :NA


Just because a room's reservation range doesn't overlap once, doesn't mean the room isn't reserved on that date.

CheezItMan · 2018-09-17T03:04:37Z

spec/tracking_system_spec.rb

+    end
+
+    it "raises an ArgumentError if no reservations are available on given date" do
+      expect{@tracker.view_reservations_on(Date.new(3333,10,5))}.must_raise ArgumentError


Why raise an error, why not just return an empty list?

CheezItMan · 2018-09-17T03:06:00Z

spec/tracking_system_spec.rb

+      expect(@available_rooms[0]).must_be_kind_of Room
+    end
+
+    it "raises ArgumentError if no rooms are available on these dates(aka they're in a block or reserved)" do


This test assumes too much detail about how Room is implemented. Instead what you could do is add 20 reservations on a given date using TrackingSystem' s method. Then try making a 21st reservation on the same date range.

CheezItMan · 2018-09-17T03:06:34Z

spec/tracking_system_spec.rb

+      @reservations = @tracker.add_reservation(start_time: Date.new(2018,8,1), end_time: Date.new(2018,8,25), number_of_rooms:1)
+      @reservations = @tracker.add_reservation(start_time: Date.new(2018,8,1), end_time: Date.new(2018,8,25), number_of_rooms:6)
+      list = @tracker.reservations
+      expect(@reservations).must_be_kind_of Array


This is more testing reservations instead of add_reservation

CheezItMan · 2018-09-17T03:08:08Z

spec/tracking_system_spec.rb

+    it "raises ArgumentError if there are not enough available-rooms on the requested date" do
+      expect{@tracker.add_reservation(start_time: Date.new(2018,1,1),end_time:Date.new(2018,1,2),number_of_rooms:350)}.must_raise ArgumentError
+    end
+


You should also test that if you make 2 reservations in the same date range, they are for different rooms.

Also test that you can make a reservation on the same date as another reservation ends.

CheezItMan · 2018-09-17T03:08:57Z

spec/tracking_system_spec.rb

+    end
+  end
+
+  describe "#retrieve_block_dates" do


I would suggest using a block Id number instead of a symbol just because it's easier to work with.

kayxn23 added 30 commits September 4, 2018 13:46

guard is working and required in spec folder

24eb5e5

set up project files and specs for reservation, room, tracking_system…

3cb6812

… classes

in the process of writing 'make_reservatoin' on Room class

1c9fc08

created add_rooms method to TrackingSystem class, and created make_re…

267e85c

…servatoin method in TrackingSystem class, tests passing but still need to refactor for more reasonable usability

refactored #make_reservation method within TrackerSystem to add its r…

3ab0b97

…eturn value to the @Reservations list

modified make_reservation method in TrackingSystem, still working on …

1de1666

…refactoring this code and creating helper methods"

updated pseudocode for make_reservation class, need to write tests

4e4c735

created spec/test_data/ folder with test data

8172d81

updated Resevation attribute from @room_num to @rooms to accomodate m…

fbd7297

…ultiple rooms in one reservation

deleted Room attribute @price because Reervation already has the pric…

d6de8f4

…e attribute

fixed bug in Reservation instantiation,unwanted comma. 13 tests, 25 a…

9f211ed

…ssertions, 2 failures(failures surrounding create reservation )

all tests passing right now, need to work on creating new tests for m…

052e51f

…ake_reservation method

require simplecov and SimpleCov.start

6f14c02

require files in lib in the spec_helper

1e4bee3

fixed bug in make_reservation method, now Reservation.rooms array col…

3a05013

…lects the room number that is reserved

added view_available_rooms_on method in TrackerSystem, and created tw…

7a7a957

…o tests, all tests passing

fixed bug that was in view_available_rooms_on in TrackingSystem class…

ba3c561

…. now the method returns an array of available rooms

created new tests for .view_available_rooms_on method, just one test …

de0cc70

…failing, need to increase coverage

tests passing, in #view_available_rooms_on specific date range, argum…

4d5d161

…ent error is raised appropriately

made some small changes, cleaning up tracking_system.rb to get rid of…

0fac79e

… unnecessary comments

updated make_reservation method with corrected keyword arguments

e4a83e4

updated Reservation.rooms to Reservation.room to be a kind of Integer…

deda7ec

… rather than Array. Each reservation just stores one room

fixed bug in #add_reservation method, all tests passing, refactored t…

2ba796f

…his method as well

wrote tests for #add_reservation, tests passing

d9e2e51

working on #total_cost_of_reservation method, writing test1,all is go…

1239005

…ing as expected

need to edit #total_cost_of_reservation to sum the nightly fee

f6481eb

fixed bug in #add_reservation, when creating new reservation the room…

72ca3bb

…_num: was num:

moved #total_cost method to Reservation class, but still keeping some…

e22a508

… commented out code blocks in TrackingSystem to see if I'll call on that method from TS later

created #view_reserations_on(date) method in TrackingSystem, ned to u…

adc68d5

…pdate tests

nothing much changed in view_reservations_on method, preparing for push

bc39470

kayxn23 added 13 commits September 8, 2018 11:17

fixed bug in tests for #view_reservations_on(date) method, now there …

d0fc68d

…are 3 tests for this method, all tests passing

added extra test to #add_reservation method, all tests passing, 99.41…

a256d49

…% coverage

added some block functionalities/limitations to view_available_rooms_…

a3883d5

…on method

created #add_block() method with a few tests so far

2d42e21

wrote tests for #rooms_available_in_block and fixed bugs in method

d02dec3

fixed bug in #rooms_available_in_block

b851b5e

cleaned up some comments from tests/lib, writing more tests for methods

5e01217

fixed bug in #add_reservation method so that it does not return rooms…

9e39a86

… that are already in a block

added tests to #retrieve_block_dates

7083fb0

fixed bug in #rooms_available_in_block, it needed a condition for if …

8c93299

…all rooms were available

fixed another bug in #rooms_available_in_block, boolean on line 149 i…

93077a0

…n TrackingSystem class should be !=

test for #add_reservation_in_block was having issues on line 270 didn…

63bbd8e

…'t recognize id as a Symbol

created refactors.txt

1a82988

CheezItMan reviewed Sep 17, 2018

View reviewed changes

kayxn23 added 3 commits September 30, 2018 15:15

added design-activity

efbadfa

added design-activity.md

41eb3d2

design activity changes

0f2a7dc

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

hotel.rb #24

hotel.rb #24

kayxn23 commented Sep 10, 2018

CheezItMan commented Sep 17, 2018

CheezItMan Sep 17, 2018

CheezItMan Sep 17, 2018

CheezItMan Sep 17, 2018

CheezItMan Sep 17, 2018

CheezItMan Sep 17, 2018

CheezItMan Sep 17, 2018

CheezItMan Sep 17, 2018

CheezItMan Sep 17, 2018

CheezItMan Sep 17, 2018

CheezItMan Sep 17, 2018

hotel.rb #24

Are you sure you want to change the base?

hotel.rb #24

Conversation

kayxn23 commented Sep 10, 2018

Hotel

Comprehension Questions

CheezItMan commented Sep 17, 2018

Hotel

What We're Looking For

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment