Leanna/Shelan's Adagram #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Our answers are in the github folder inside adagrams.rb |
AdagramsWhat We're Looking For
|
CheezItMan
reviewed
Aug 22, 2018
| # #-------------WAVE-1--PASS----------------- | ||
| def draw_letters | ||
| #string of letters of the correct quantity | ||
| letters = ("A" * 9) + ("B" * 2) + ("C" * 2) + ("D" * 4) + ("E" * 12) + ("F" * 2) + ("G" * 3) + ("H" * 2) + ("D" * 4) + ("E" * 12) + ("F" * 2) + ("G" * 3) + ("H" * 2) + ("I" * 9) + ("J" * 1) + ("K" * 1) + ("L" * 4) + ("M" * 2) + ("N" * 6) + ("O" * 8) + ("P" * 2) + ("Q" * 1) + ("R" * 6) + ("S" * 4) + ("T" * 6) + ("U" * 4) + ("V" * 2) + ("W" * 2) + ("Y" * 2) + ("Z" * 1) |
| if letters_in_hand.include?(let) #if the input letter matches a letter in hand | ||
| tru_fals << letters_in_hand.delete_at(letters_in_hand.index(let)) #delete letter from the one in hand & push to tru_fals | ||
| else | ||
| tru_fals << false #if no match, pushes false |
There was a problem hiding this comment.
why not just return false at this point?
| if score == winner[:score] #only exceptions are ties | ||
|
|
||
| if winner[:word].length == 10 | ||
| winner[:word] = winner[:word] |
There was a problem hiding this comment.
Here you're swapping the word with itself. Seems unnecessary
| winner[:score] = score | ||
|
|
||
| elsif word.length == 10 && winner[:word].length == 10 | ||
| winner[:word] = winner[:word] |
There was a problem hiding this comment.
Again repetition, this elsif is redundant.
| winner[:word] = winner[:word] | ||
| winner[:score] = winner[:score] | ||
|
|
||
| elsif word.length < winner[:word].length && word.length != 10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adagrams
Congratulations! You're submitting your assignment.
Comprehension Questions
Enumerablemixin? If so, where and why was it helpful?