-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maddie Shields - Edges - MediaRanker #50
base: master
Are you sure you want to change the base?
Conversation
I'm not going to give a full review for this incomplete submission, but I do want to give some feedback about what I'm seeing. You have most of the controller work done for waves 1 and 2, including Work CRUD, logging in and voting. This controller code looks pretty solid - I'm not a compiler, but I didn't spot any obvious bugs. However, you don't have any views, which means there's no way to actually run any of the controller actions. This indicates to me that, beyond any holes in your understanding of the curriculum, there's a major issue with your process for writing code. You should be running you code regularly to see whether it works. Every time you build a piece of your site, you should find a way to try it out. In the context of Rails, that means:
This does two things:
Both of these will help you to write cleaner, less buggy code faster. Getting students to run their code and try it out piece by piece is part of why we structure projects in waves - the hope is that if wave 1 is complete, from the database to the views, that gives a solid foundation to work on wave 2. Your development feedback cycle should be even tighter than that (typically no more than 4 or 5 lines of code before trying it out), but the waves give it a little more structure. This idea of having a tight feedback loop between writing code and seeing the result is one of the core tenants of agile programming. In agile we usually think about it in the context of release cycles and getting feedback from customers, but it applies equally well to the development cycle where you are acting as the user, giving feedback to yourself. |
Media Ranker
Congratulations! You're submitting your assignment!
Comprehension Questions
session
andflash
? What is the difference between them?