Carly Reiter - Edges - Media Ranker revisited #27

CarlyReiter · 2018-10-30T11:31:02Z

No description provided.

…g a user (:dan) who had votes.

…d request.

… and then adding.

…nts of uid and provider.

…ing or not voting for works.

…roke everything...

droberts-sea · 2018-10-31T22:38:52Z

MediaRanker Revisted

Feature	Feedback
General
Appropriate Tests on WorksController	yes (except for authorization rules)
Appropriate Tests on SessionsController	missing tests for login
Appropriate Tests on UsersController	yes
Completed OAuth
Basic Authorization (who can see what)	no - looks like you were close on this, but the `require_login` controller filter is commented out.
Overall	Good work overall. If you find time to do some extra studying, it would be worth reviewing authorization, both implementation and testing.

CarlyReiter added 21 commits October 15, 2018 14:29

migrated database and then seeded it.

9b14215

initial show and index tests for User controller.

358fa49

changed the invalid user to last + 1 because ran into trouble deletin…

400729a

…g a user (:dan) who had votes.

initial show and new tests.

2e40836

changed work controller update method, per Slack request, to read :ba…

da9da24

…d request.

completed tests for work controller index.

138468f

updated root testing of works controller.

8f28983

updated root testing for works to use where instead of destroying all…

fbac52a

… and then adding.

testing for edit of works controller.

d96f19c

completed initial testing for create in works controller.

e88a6a1

completed update tests for works controller.

1286121

cleaned up comments.

5adfe26

testing for destroy in works controller.

9e1f0d4

updated delete action testing in works controller.

e9796a9

completed upvote testing.

7169dd5

oauth setup, through route setup.

b4e0480

continued to figure out signing in through gitbub

0f0d2b2

finished logging in with oauth through class.

ed25f1b

refactored model and controller tests to relate to new user requireme…

561d682

…nts of uid and provider.

completed final two tests for works controller and logged in user vot…

c9344cf

…ing or not voting for works.

added control filter to require logging in to create a work, but it b…

bc3b3c4

…roke everything...