Lib to template #76
Merged
Lib to template #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olejnjak
force-pushed
the
lib_to_template
branch
from
f9e637d to
61a340a
Compare
olejnjak
force-pushed
the
lib_to_template
branch
2 times, most recently
from
758febb to
3f10917
Compare
olejnjak
force-pushed
the
lib_to_template
branch
from
3f10917 to
a863aec
Compare
olejnjak
force-pushed
the
lib_to_template
branch
from
3be32dd to
562f419
Compare
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
LukasHromadnik
approved these changes
Mar 24, 2024
olejnjak
added a commit
that referenced
this pull request
Mar 24, 2024
* 🔥 Remove template lib * 🔧 Update CI * 🔥 Remove Carthage build * 🔧 Fix install tuist * 🔧 Comment out changelog check * 🔧 Fix install tuist * 🔧 Use Xcode 15.2 * 🔧 Fix install tuist * 🔧 Use FirebaseFetcher in example app * 🔧 Remove underscores from target names * 📝 Update docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we moved pretty much everything to ACKategories, the template lib is now unnecessary.
The only thing that remained here is
FirebaseFetcher. And here I would suggest either copying that single file into project, or implementing it through Carthage/Checkouts which would work.Also I implemented here some stuff we have talked about on last meeting - removing underscores from module names and renaming Core module to AppCore.
There are some other stuff like updating CI.