Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing "testing" object #1852

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Introducing "testing" object #1852

merged 2 commits into from
Oct 14, 2024

Conversation

JeanChristopheMorinPerso
Copy link
Member

This PR will merge the testing_object branch that I used to stage #1740 while I was fixing the tests. I didn't want to merge #1740 in main with failing tests.

* Introducing 'testing' object

Signed-off-by: Fabrice Macagno <[email protected]>
Signed-off-by: Nathan Cheung <[email protected]>
Co-authored-by: Jean-Christophe Morin <[email protected]>
Co-authored-by: Nathan Cheung <[email protected]>
@JeanChristopheMorinPerso JeanChristopheMorinPerso requested a review from a team as a code owner October 14, 2024 17:23
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.30%. Comparing base (84c827d) to head (07abf44).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1852      +/-   ##
==========================================
+ Coverage   58.58%   59.30%   +0.72%     
==========================================
  Files         126      126              
  Lines       17207    17210       +3     
  Branches     3015     3015              
==========================================
+ Hits        10080    10206     +126     
+ Misses       6474     6319     -155     
- Partials      653      685      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JeanChristopheMorinPerso JeanChristopheMorinPerso added this to the Next milestone Oct 14, 2024
Signed-off-by: Jean-Christophe Morin <[email protected]>
@JeanChristopheMorinPerso JeanChristopheMorinPerso merged commit 491497f into main Oct 14, 2024
88 checks passed
@JeanChristopheMorinPerso JeanChristopheMorinPerso deleted the testing_object branch October 14, 2024 17:35
@JeanChristopheMorinPerso JeanChristopheMorinPerso removed this from the Next milestone Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants