Add support for overriding built-in bind modules #1619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lt-in bind modules. Signed-off-by: Michael Nowakowski <[email protected]>
Pantsworth
force-pushed
the
issue_1557-package-bind-override
branch
from
fd9242b to
980eab9
Compare
JeanChristopheMorinPerso
changed the title
Signed-off-by: Jean-Christophe Morin <[email protected]>
Signed-off-by: Jean-Christophe Morin <[email protected]>
JeanChristopheMorinPerso
approved these changes
Jan 27, 2024
JeanChristopheMorinPerso
merged commit 082ce72
into
AcademySoftwareFoundation:main
55 checks passed
Pixel-Minions
pushed a commit
to Pixel-Minions/rez
that referenced
this pull request
Feb 14, 2024
…dation#1619) * Issue AcademySoftwareFoundation#1557 - Add support for overriding built-in bind modules. Signed-off-by: Michael Nowakowski <[email protected]> * Add copyrights Signed-off-by: Jean-Christophe Morin <[email protected]> * Add test for get_bind_modules Signed-off-by: Jean-Christophe Morin <[email protected]> --------- Signed-off-by: Michael Nowakowski <[email protected]> Signed-off-by: Jean-Christophe Morin <[email protected]> Co-authored-by: Jean-Christophe Morin <[email protected]> Signed-off-by: Jose Enriquez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1557
This PR allows modules defined in
config.bind_module_pathto override builtin bind modules (and adds a test to verify the behavior).This enables users to customize how Rez creates bind packages (like
osandarch) to match their needs.