Merge GH Actions workflows that run tests into a single workflow #1611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jean-Christophe Morin <[email protected]>
…ests to make sure the tests are using the right shell Signed-off-by: Jean-Christophe Morin <[email protected]>
Signed-off-by: Jean-Christophe Morin <[email protected]>
package instead of a python script. Signed-off-by: Jean-Christophe Morin <[email protected]>
…ends on make and GCC Signed-off-by: Jean-Christophe Morin <[email protected]>
…our test packages. This will hopefully fix issues when there is no system python available. Signed-off-by: Jean-Christophe Morin <[email protected]>
Signed-off-by: Jean-Christophe Morin <[email protected]>
Signed-off-by: Jean-Christophe Morin <[email protected]>
Signed-off-by: Jean-Christophe Morin <[email protected]>
JeanChristopheMorinPerso
force-pushed
the
simplify_ci
branch
from
8e4aad3 to
5e096a7
Compare
…ith 3.8 in test workflow Signed-off-by: Jean-Christophe Morin <[email protected]>
JeanChristopheMorinPerso
force-pushed
the
simplify_ci
branch
from
c073ae6 to
1626949
Compare
JeanChristopheMorinPerso
merged commit 222ee07
into
AcademySoftwareFoundation:main
54 of 55 checks passed
Pixel-Minions
pushed a commit
to Pixel-Minions/rez
that referenced
this pull request
Feb 14, 2024
…demySoftwareFoundation#1611) * Merge GH Actions workflows that run tests into a single workflow * Configure default_shell when using per_available_shell decorator in tests to make sure the tests are using the right shell * Add test for per_available_shell decorator does what it's supposed to * Fix shell tests on Windows by creating an executable for the hello_world package instead of a python script. * Skip test_build::TestBuild::test_build_custom on Windows since it depends on make and GCC * Create a python rez package on the fly and use it as a dependency on our test packages. This will hopefully fix issues when there is no system python available. * Fix linter warnings * Remove old workflows * Fix test_deprecation_from_user_config on Windows * Add python 3.8, 3.9, 3.0 and 3.11 to installation workflow and test with 3.8 in test workflow --------- Signed-off-by: Jean-Christophe Morin <[email protected]> Signed-off-by: Jose Enriquez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge GH Actions workflows that run tests into a single workflow.
Changes:
per_available_shelldecorator now setsconfig.default_shellto enforce the default shell when used. This avoids mistakes where we forget to callconfig.override("default_shell", shell)in tests decorated withper_available_shell. About a dozen or more tests were simply not testing any other shell then the current default shell (including all the shell tests!)..PYto be inPATHEXTon Windows. This is very error prone. This is now fixed by wrapping the python code into an executable usingdistlib(like pip does with entry points).rez-selftestwill now create a "python" rez package that is used by our test packages (for building, etc) to fix issues when there is no executablepythonon a system. This also removes the implicit dependency in our test packages. Note that the python package simply contains a virtualenv. That's very simple and does the trick. We don't really care about which version of python we need anyway. We just need a python interpreter.All these changes are required due to dropping the docker images on Windows and also due to the fact that we are now using
macos-latest, which doesn't have apythonexecutable (it only haspython3).