-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: @abstract-money/cli
#7
Merged
dalechyn
merged 11 commits into
mainline
from
vlad/app-247-implement-the-code-generation-poc-for-react-and-cosmoskit
Dec 26, 2023
Merged
feat: @abstract-money/cli
#7
dalechyn
merged 11 commits into
mainline
from
vlad/app-247-implement-the-code-generation-poc-for-react-and-cosmoskit
Dec 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: 0 B Total Size: 122 kB ℹ️ View Unchanged
|
Turns out I forgot to install some dependencies to the `cli` package and it made ESBuild to go crazy. I also had to implement a hack to replace the in the field with a callback since it is a required plugin as of now. It will not be required in the future versions of the cli.
It makes more sense to have it as a part of the `react` plugin configuration.
@carina-akaia I suggest merging it to be used later in the payments app. the test coverage will come in future prs. |
carina-akaia
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.