[APP-243] feat: revive monorepo #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is work in progress. The proposed monorepo change would allow us ship both CJS, ESM and DTS files split in different proxy packages for better tree-shacking purposes. As well as it "fixes" (and ignores) some of the issues within the `core` package, and yet needs more type-safety fixes on `react` package.
Deploying with
|
| Latest commit: |
befaad4
|
| Status: | 🚫 Build failed. |
|
Size Change: 0 B Total Size: 109 kB ℹ️ View Unchanged
|
|
Size job fails but should be operating normally after the merge. Post-action bug in there. |
adairrr
reviewed
Dec 1, 2023
examples/wagemos-app-nextjs/src/app/_components/connect-button.tsx
Outdated
Show resolved
Hide resolved
Comment on lines
76
to
87
| const { | ||
| data: wagemosQueryClient, | ||
| isLoading: isWagemosQueryClientLoading, | ||
| isError: isWagemosQueryClientError, | ||
| error: wagemosQueryClientError, | ||
| } = useModuleQueryClient( | ||
| { | ||
| moduleId: WAGEMOS_MODULE_ID, | ||
| Module: WagemosAppQueryClient, | ||
| }, | ||
| { enabled: options?.enabled }, | ||
| ) |
There was a problem hiding this comment.
Perhaps we should also pull this into an autogenerated hook useWagemosQueryClient
There was a problem hiding this comment.
could you describe a bit more what do you mean?
| }, | ||
| }) | ||
|
|
||
| export type AbstractProviderProps = AbstractConfigProps |
There was a problem hiding this comment.
We should probably allow the consumer to provide query client options as well - this is what graz does https://github.com/graz-sh/graz/blob/2dd73ddae3313e76be5f79215a30c0916c9c1fcd/packages/graz/src/provider/index.tsx#L2
There was a problem hiding this comment.
or a client should instead init the query client on his side and inject it into the provider, we could build a fancy createConfig as wagmi did.
Also commented out the dev build for the package, since nextjs example tries to transpile it and requries dependencies to be installed.
Unfortunately I am meeting building issues again.
Turned out to be a bad remapping to the package path.
Still having return type annotations issues.
It turned out that `tsup`s `dts` flag has been generating incorrect typings, so I tried using `experimentalDts` and it worked. `react` package won't use this option though, since it doesn't work there. DTS building is a wild world.
|
@adairrr lint, build, types jobs pass. |
carina-akaia
suggested changes
Dec 7, 2023
carina-akaia
approved these changes
Dec 7, 2023
adairrr
approved these changes
Dec 8, 2023
Comment on lines
+62
to
+86
| const onSubmit: SubmitHandler<z.infer<typeof placeBetSchema>> = useCallback( | ||
| async ({ amount, accountSeq }) => { | ||
| const accountIdToBetOn = round.teams.find( | ||
| (account) => account.seq === +accountSeq, | ||
| ) | ||
| if (!accountIdToBetOn) throw new Error('Account not found') | ||
|
|
||
| await placeBetAsync?.({ | ||
| msg: { | ||
| roundId: round.id, | ||
| bet: { | ||
| account_id: accountIdToBetOn, | ||
| asset: { name: round.total_bet.name, amount: amount.toString() }, | ||
| }, | ||
| }, | ||
| }) | ||
|
|
||
| setIsOpen(false) | ||
| toast({ | ||
| title: 'Bet placed', | ||
| description: `You bet ${amount} ${round.total_bet.name} on account ${accountIdToBetOn.seq}`, | ||
| }) | ||
| }, | ||
| [placeBetAsync], | ||
| ) |
There was a problem hiding this comment.
nit small design question :
Is this generally the best way to deal with mutations in react-query? From what I've seen we want to avoid using the async mutation and add additinoal mutations in the components with the onSuccess and onError handlers
There was a problem hiding this comment.
While react-query allows both, I assume it is safe to use both variants unless the post-mutation logic is triggered more than once.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is work in progress.
The proposed monorepo change would allow us ship both CJS, ESM and DTS files split in different proxy packages for better tree-shacking purposes.
As well as it "fixes" (and ignores) some of the issues within the
corepackage, and yet needs more type-safety fixes onreactpackage.Implements APP-243 (https://linear.app/abstract-sdk/issue/APP-243/refactor-the-current-sdk)