tools/trace-parser: Add Rust trace.dat parser #2166
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
douglas-raillard-arm
force-pushed
the
_home_pr90383
branch
30 times, most recently
from
4ec9117 to
399137b
Compare
douglas-raillard-arm
force-pushed
the
_home_pr90383
branch
8 times, most recently
from
fc9d40f to
0c0ac4e
Compare
BREAKING CHANGE cpumask fields cannot be handled in a uniform way between all parsers, so remove any attempts at doing so. Since the new default trace-dump parser has direct support for them, drop the sanitization. The new format for cpumask values is an iterable of booleans where each position corresponds to one bit, starting from CPU 0, e.g. [True, False, False] for the cpumask 0b100
FIX Clear the flag in the file that states that some events were dropped. This avoids parsing to fail because of dropped events detection.
FIX Fix buffer name parsing so that we do not accidentally consume part of the comm field.
douglas-raillard-arm
force-pushed
the
_home_pr90383
branch
5 times, most recently
from
fd1c665 to
46cfc71
Compare
FEATURE
Switch the parser for trace.dat format to the new trace-dump parser.
Also make a number of changes to the parsing infrastructure:
* New trace-id parser metadata that is used instead of md5 checksum when
available.
* Meta events are now tried directly before their source event, so the
parser has a chance to handle that directly. This is critical for
trace_printk@ performance as the new parser handles it natively.
* TraceParserBase subclasses are now used as a context manager when
costly operation such as event parsing (always) or metadata querying
(only when the result is really needed). This allows the parser to
correctly manage its resources, while allowing cheap metadata
gathering to happen as part of the constructor if needed.
* A number of fixes such as minimzation of parsing attempts if an event
is known to not be parseable.
* available-events metadata are now cached in the trace cache.
* Removed the multiprocessing parsing from lisa.trace.Trace. This is
effectively useless with the new parser (which is parallel on its own)
and avoids pitfalls of forking Python process (sluggish import time or
crashy/illegal libc calls after fork, pick your poison)
If need be, the old parser is still available and can be used as:
Trace(..., parser=TxtTraceParser.from_dat)
However, it is not expected that the old parser has any use beyond some
meta events (userspace@...) so if you have problems with the new one,
please open a bug report with the trace.dat.
douglas-raillard-arm
force-pushed
the
_home_pr90383
branch
from
46cfc71 to
9f9e90d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FEATURE