Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend smbios #108

Closed
wants to merge 1 commit into from
Closed

Recommend smbios #108

wants to merge 1 commit into from

Conversation

vstehle
Copy link
Collaborator

@vstehle vstehle commented Sep 8, 2023

Start easy and just add details about the SMBIOS tables and structures, with a reference to the SMBIOS specification v3.7.0.
Should we remove the conditional and require SMBIOS?

@nullr0ute
Copy link
Collaborator

Should we remove the conditional and require SMBIOS?

Yes, I think we should. A lot of support tools use SMBIOS to provide information to users in a GUI/TUI and collect information for support cases. By propagating that information the existing versions of these tools will just function as expected and we don't have to try and boil the ocean to get everything updated to support other mechanisms. It's also a requirement of ServerReady so it allows alignment across all SystemReady certs.

@nullr0ute
Copy link
Collaborator

Example tool is sosreport and an example issue with a GUI management tool

@vstehle
Copy link
Collaborator Author

vstehle commented Sep 27, 2023

Rebased.

@nullr0ute
Copy link
Collaborator

Should we have somewhere in the spec around suggesting/requiring SMBIOS tables to be presented and complete/accurate?

@nullr0ute
Copy link
Collaborator

@samerhaj
Copy link

One solution is for EBBR to reference specific items from Base Boot Requirements (BBR) specification, section 9 - SMBIOS REQUIREMENTS.

It is also possible to do it the other way around (or both ways), where the BBR specification (which already references EBBR spec, when defining the EBBR receipe) can detail the SMBIOS requirements for such systems. I can help with adding that language (or cross-reference) in BBR when needed.

@vstehle
Copy link
Collaborator Author

vstehle commented Jan 10, 2024

Rebased.

@vstehle vstehle force-pushed the smbios branch 2 times, most recently from 6f3f3f2 to 64bc0c4 Compare February 22, 2024 11:09
@vstehle vstehle force-pushed the smbios branch 3 times, most recently from 8712506 to 05203fc Compare February 29, 2024 15:48
@vstehle
Copy link
Collaborator Author

vstehle commented Feb 29, 2024

I have updated this pull request to require SMBIOS and a few structures, starting with the ones both required in BBR v2.0 and implemented in U-Boot latest.

@vstehle vstehle changed the title Add smbios tables details Require smbios Feb 29, 2024
@vstehle
Copy link
Collaborator Author

vstehle commented Mar 12, 2024

Moving to draft after call of 11 Mar.

@vstehle vstehle marked this pull request as draft March 12, 2024 13:32
@vstehle
Copy link
Collaborator Author

vstehle commented Mar 12, 2024

Respun after call of 11 Mar:

  • Only "strongly recommend" SMBIOS, and when implemented require structures
  • Remove Type 32 from table of required structures
  • Warn that SMBIOS will be required in the future
  • Add a note to clarify that firmware can provide more than what is required

- Strongly recommend SMBIOS, without requiring any specific table or
  structure for now.
- Add a reference to the SMBIOS specification v3.7.0.

Suggested-by: Peter Robinson <[email protected]>
Signed-off-by: Vincent Stehlé <[email protected]>
@vstehle
Copy link
Collaborator Author

vstehle commented Jun 14, 2024

Trim down even more: only recommend SMBIOS and do not require any specific structure or table.

@vstehle vstehle marked this pull request as ready for review June 14, 2024 09:03
@vstehle vstehle changed the title Require smbios Recommend smbios Jun 14, 2024
SMBIOS
------

It is strongly recommended that firmware provides SMBIOS tables and structures.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should require that the information is provided as EFI configuration table:

It is strongly recommended that firmware provides an SMBIOS EFI configuration table with an SMBIOS 3.0 (64-bit) Entry Point and at least the following SMBIOS tables:

  • BIOS Information (Type 0)
  • System Information (Type 1)
  • Baseboard (or Module) Information (Type 2)
  • System Enclosure or Chassis (Type 3)
  • Processor Information (Type 4)

described in :UEFI:`4.6.1.1` and [SMBIOS]_ § 5 & 6.

.. warning:: A future version of this specification will require firmware to
provide SMBIOS tables and strutures and will explicitly list which ones are
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

%s/strutures/structures/

@vstehle
Copy link
Collaborator Author

vstehle commented Jun 18, 2024

Dropping this pull request after the call of June 17; there is not enough remaining in the pull to be interesting.
Let's revive it later on.

@vstehle vstehle closed this Jun 18, 2024
@vstehle vstehle deleted the smbios branch June 18, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants