Fail early when trying to convert a jpeg+gainmap image without libxml2. #2526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrabaud
approved these changes
Dec 20, 2024
wantehchang
reviewed
Dec 20, 2024
| std::cout << "JPEG gainmap conversion unavailable because avifgainmaputil " | ||
| "was not built with libxml2.\n"; | ||
| return AVIF_RESULT_NOT_IMPLEMENTED; | ||
| #endif |
There was a problem hiding this comment.
I suggest enclosing the rest of the function in a #else block. Otherwise, some compilers may warn that the code afterthe return statement (line 37) is not reachable.
There was a problem hiding this comment.
Done in #2530. Coverity warns about it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.