Turn gain map flag on by default. #2513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove 'EXPERIMENTAL' from its name.
wantehchang
reviewed
Dec 2, 2024
wantehchang
reviewed
Dec 3, 2024
wantehchang
approved these changes
Dec 3, 2024
| @@ -676,7 +677,7 @@ if(AVIF_BUILD_APPS OR (AVIF_BUILD_TESTS AND (AVIF_ENABLE_FUZZTEST OR AVIF_ENABLE | |||
| find_package(JPEG REQUIRED) | |||
| endif() | |||
|
|
|||
| if(AVIF_ENABLE_EXPERIMENTAL_GAIN_MAP) | |||
| if(AVIF_ENABLE_GAIN_MAP) | |||
There was a problem hiding this comment.
Should we remove EXPERIMENTAL from AVIF_ENABLE_EXPERIMENTAL_JPEG_GAIN_MAP_CONVERSION?
Can do this in a follow-up CL.
|
I kept the AVIF_ENABLE_GAIN_MAP option for now just in case we needed to revert it to OFF for some reason, and to keep this PR simple (even though the rename means that there are still quite a few changes). |
|
As for AVIF_ENABLE_EXPERIMENTAL_JPEG_GAIN_MAP_CONVERSION, since it's still off by default, I kept the "experimental" name for now. Again, can be changed later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove 'EXPERIMENTAL' from its name.