[FEAT/#11] 7주차 과제 #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitsuhyun
approved these changes
Dec 19, 2024
| import kotlinx.coroutines.flow.asStateFlow | ||
| import kotlinx.coroutines.launch | ||
|
|
||
| abstract class BaseViewModel<State : UiState, SideEffect : UiSideEffect, Event : UiEvent> : ViewModel() { |
There was a problem hiding this comment.
baseViewModel을 추가해서 sideEffect와 event를 쉽게 관리해줄 수 있군용
Comment on lines
+26
to
+31
| override suspend fun handleEvent(event: MyPageEvent) { | ||
| when (event) { | ||
| is MyPageEvent.LoadUserHobby -> { | ||
| val token = sharedPreferences.getString(TOKEN, "").orEmpty() | ||
| if (token.isNotEmpty()) { | ||
| getHobby(token) |
| import org.sopt.and.core.component.UiSideEffect | ||
| import org.sopt.and.core.component.UiState | ||
|
|
||
| class MyPageContract { |
jihyunniiii
reviewed
Dec 25, 2024
Comment on lines
+51
to
+53
| hilt { | ||
| enableAggregatingTask = false | ||
| } |
There was a problem hiding this comment.
요 코드가 왜 작성되어야 하는지 어떻게 하면 작성하지 않아도 되는지 공부해보시면 좋을 것 같아요
| val hobby = response.result.hobby | ||
| if (hobby.isNotEmpty()) { | ||
| _hobby.value = hobby | ||
| override suspend fun handleEvent(event: MyPageEvent) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
Uncompleted Tasks 😅
To Reviewers 📢
7주차 과제 조금 늦었습니다 .. 죄송합니다 ..
리뷰 달아주시면 적극 반영하겠습니다 ! 아직 MVI를 제대로 적용한건지 모르겠네요 ..