[feat/#12] 7주차 과제 구현 #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kangyein9892
requested review from
jm991014,
boiledEgg-s,
jihyunniiii and
serioushyeon
Open
3 tasks
serioushyeon
approved these changes
Dec 18, 2024
| data class SnackBar(@StringRes val message: Int): MySideEffect() | ||
| data class SnackBarText(val message: String): MySideEffect() | ||
| data object Logout: MySideEffect() | ||
| data object NavigateToSignIn: MySideEffect() |
| val intent = _intent.asSharedFlow() | ||
| override suspend fun handleEvent(event: MyEvent) { | ||
| when(event) { | ||
| MyEvent.OnLogoutButtonClick -> { |
| fun onLogOutButtonClick() = viewModelScope.launch { | ||
| _intent.emit(MySideEffect.Logout) | ||
| private fun navigateToSignIn() = viewModelScope.launch { | ||
| delay(100) |
jm991014
approved these changes
Dec 18, 2024
Comment on lines
+68
to
+70
| is SignInSideEffect.SnackBarText -> snackBarHostState.showSnackbar(sideEffect.message) | ||
| SignInSideEffect.NavigateToSignUp -> { | ||
| navigateToSignUp() |
There was a problem hiding this comment.
위에도 있는 질문인데 is의 유무로 인해 어떤 차이가 있는 건가요!?
| fun onLogOutButtonClick() = viewModelScope.launch { | ||
| _intent.emit(MySideEffect.Logout) | ||
| private fun navigateToSignIn() = viewModelScope.launch { | ||
| delay(100) |
boiledEgg-s
approved these changes
Dec 18, 2024
| fun onLogOutButtonClick() = viewModelScope.launch { | ||
| _intent.emit(MySideEffect.Logout) | ||
| private fun navigateToSignIn() = viewModelScope.launch { | ||
| delay(100) |
| } | ||
|
|
||
| fun clearUserPreference() = viewModelScope.launch { | ||
| userRepository.clearUserPreference() | ||
| } | ||
|
|
||
| suspend fun handleMyIntentError(message: String) { | ||
| _intent.emit(MySideEffect.SnackBarText(message)) | ||
| fun handleMyIntentError(message: String) = viewModelScope.launch { |
There was a problem hiding this comment.
UI단에서 이미 코루틴을 사용하는 것으로 보이는데, suspend를 지우고 viewModelScope를 넣으신 이유가 있나요?
jihyunniiii
reviewed
Dec 25, 2024
Comment on lines
+68
to
+70
| is SignInSideEffect.SnackBarText -> snackBarHostState.showSnackbar(sideEffect.message) | ||
| SignInSideEffect.NavigateToSignUp -> { | ||
| navigateToSignUp() |
| _state.update { | ||
| it.copy(hobby = result.hobby) | ||
| } | ||
| setState { copy(hobby = result.hobby) } |
There was a problem hiding this comment.
석준 오빠 코드리뷰 읽어보시면 좋을 듯 합니다! 이해 안 되면 저 디코로 호출하3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
화면 바뀐 부분은 없습니다 !
To Reviewers 📢