[FEAT/#10] 6주차 필수 과제 #11

yihwanggeun · 2024-12-06T13:26:19Z

Related issue 🛠

closed [FEAT] WEEK6 필수 과제 #10

Work Description ✏️

Clean Architecture or Google Recommended Architecture 구현

Screenshot 📸

Uncompleted Tasks 😅

Hilt적용

To Reviewers 📢

RepositoryPool을 사용하니 클래스엮임이 더 심해진 것 같은데 이런 아키텍처에는 RepositoryPool을 적용하면 안 되는 것인가요?

object RepositoryPool {
    val hobbyRepository: HobbyRepository by lazy {
        HobbyRepositoryImpl(HobbyDataSourceImpl(ServicePool.hobbyService))
    }

    val signInRepository: SignInRepository by lazy {
        SignInRepositoryImpl(SignInDataSourceImpl(ServicePool.signInService))
    }

    val signUpRepository: SignUpRepository by lazy {
        SignUpRepositoryImpl(SignUpDataSourceImpl(ServicePool.signUpService))
    }
}

yskim6772

고생하셨습니다 ! 시간이 된다면 DI도 적용해보면 좋을 것 같아요 ~
MVI도 화이팅 !

yskim6772 · 2024-12-08T12:08:48Z

app/src/main/java/org/sopt/and/core/data/dto/BaseResponse.kt

 @Serializable
 data class BaseResponse <T> (
-    val status: Int,
-    val message: String,
-    val data: T? = null
+    @SerialName("result")
+    val result: T


BaseResponse 수정 굿 ~

yskim6772 · 2024-12-08T12:08:58Z

app/src/main/java/org/sopt/and/core/data/dto/response/CreateUserResponse.kt

 @Serializable
 data class CreateUserResponse(
-    @SerialName("result")
-    val result: Result
-) {
-    @Serializable
-    data class Result(
-        @SerialName("no")
-        val no: Int
-    )
-}
+    @SerialName("no")
+    val userId: Int


변수명도 좋네요 !

yskim6772 · 2024-12-08T12:12:14Z

app/src/main/java/org/sopt/and/core/util/DefaultErrorHandler.kt

+class DefaultErrorHandler(private val context: Context) : ErrorHandler {
+    override fun handleNetworkError(exception: Throwable?): String {
+        return when (exception) {
+            is HttpException -> when (exception.code()) {
+                400 -> context.getString(R.string.network_error_400)
+                403 -> context.getString(R.string.network_error_403)
+                409 -> context.getString(R.string.network_error_409)
+                else -> context.getString(R.string.network_error)
+            }
+            else -> context.getString(R.string.network_error)
+        }
+    }
+}


DefaultErrorHandler 좋네요
모든 API의 에러 메시지가 각 상태코드별로 서로 동일한지도 확인해보면 좋을 것 같아요 ~

에러 핸들링 함수 좋네요!!

yskim6772 · 2024-12-08T12:12:54Z

app/src/main/java/org/sopt/and/domain/repository/RepositoryPool.kt

+object RepositoryPool {
+    val hobbyRepository: HobbyRepository by lazy {
+        HobbyRepositoryImpl(HobbyDataSourceImpl(ServicePool.hobbyService))
+    }
+
+    val signInRepository: SignInRepository by lazy {
+        SignInRepositoryImpl(SignInDataSourceImpl(ServicePool.signInService))
+    }
+
+    val signUpRepository: SignUpRepository by lazy {
+        SignUpRepositoryImpl(SignUpDataSourceImpl(ServicePool.signUpService))
+    }
+}


이런 식으로 의존성 주입 로직에 관련된 코드는, viewmodelfactory라는 이름으로 생성해줘도 될 것 같아요 ~

domain 레이어에는 다른 계층, 또는 서드파티 관련 import는 없어야한다고 알고있어용 RepositoryPool을 다른 곳으로 옮기는게 어떨까요!

yskim6772 · 2024-12-08T12:13:46Z

app/src/main/java/org/sopt/and/domain/repository/SignUpRepository.kt

@@ -0,0 +1,8 @@
+package org.sopt.and.domain.repository
+
+import org.sopt.and.core.data.dto.response.CreateUserResponse


data 레이어 관련 import가 있어서 봤더니, 이 코드에서는 안 쓰이는 import인 것 같네요! 지워줍시다 ~

yskim6772 · 2024-12-08T12:14:37Z

app/src/main/java/org/sopt/and/domain/repository/SignUpRepository.kt

+import org.sopt.and.domain.entity.SignUpData
+
+interface SignUpRepository {
+    suspend fun signUp(username: String, password: String, hobby: String): Result<SignUpData>


request에 들어가는 부분도, model을 하나 생성해서 써줘도 좋을 것 같아요 !

gitsuhyun

에러 처리, 함수화 등등 전반적으로 잘 구현해주신 것 같아용 domain 레이어 부분만 신경써주시면 더 좋을 것 같습니다!! 수고하셨어요~~

gitsuhyun · 2024-12-08T13:16:56Z

app/src/main/java/org/sopt/and/core/data/dto/response/CreateUserResponse.kt

요런식으로 네이밍을 다르게 할 수 있구나 처음 알았네요!

gitsuhyun · 2024-12-08T13:18:02Z

app/src/main/java/org/sopt/and/core/util/DefaultErrorHandler.kt

+class DefaultErrorHandler(private val context: Context) : ErrorHandler {
+    override fun handleNetworkError(exception: Throwable?): String {
+        return when (exception) {
+            is HttpException -> when (exception.code()) {
+                400 -> context.getString(R.string.network_error_400)
+                403 -> context.getString(R.string.network_error_403)
+                409 -> context.getString(R.string.network_error_409)
+                else -> context.getString(R.string.network_error)
+            }
+            else -> context.getString(R.string.network_error)
+        }
+    }
+}


에러 핸들링 함수 좋네요!!

gitsuhyun · 2024-12-08T13:19:18Z

app/src/main/java/org/sopt/and/domain/repository/HobbyRepository.kt

@@ -0,0 +1,8 @@
+package org.sopt.and.domain.repository
+
+import org.sopt.and.core.data.dto.response.GetHobbyResponse


이 부분도 안쓰는 import인 것 같아용

gitsuhyun · 2024-12-08T13:23:38Z

app/src/main/java/org/sopt/and/presentation/auth/AuthViewModel.kt

 class AuthViewModel(application: Application) : AndroidViewModel(application) {

    private val context = getApplication<Application>().applicationContext

+    private val errorHandler = DefaultErrorHandler(context)


AndroidViewModel이 뭔지 찾아보니 애플리케이션 Context에 접근할 때 사용하는 거군요 굿굿!!

gitsuhyun · 2024-12-08T13:25:23Z

app/src/main/java/org/sopt/and/presentation/mypage/MyPageViewModel.kt

+            result.onSuccess { hobbyData ->
+                _uiState.value = MyPageUiState(hobby = hobbyData.hobby)
+            }.onFailure { e ->
+                _errorMessage.value = errorHandler.handleNetworkError(e)


깔끔하다!

gitsuhyun · 2024-12-08T13:28:03Z

app/src/main/java/org/sopt/and/domain/repository/RepositoryPool.kt

+object RepositoryPool {
+    val hobbyRepository: HobbyRepository by lazy {
+        HobbyRepositoryImpl(HobbyDataSourceImpl(ServicePool.hobbyService))
+    }
+
+    val signInRepository: SignInRepository by lazy {
+        SignInRepositoryImpl(SignInDataSourceImpl(ServicePool.signInService))
+    }
+
+    val signUpRepository: SignUpRepository by lazy {
+        SignUpRepositoryImpl(SignUpDataSourceImpl(ServicePool.signUpService))
+    }
+}


domain 레이어에는 다른 계층, 또는 서드파티 관련 import는 없어야한다고 알고있어용 RepositoryPool을 다른 곳으로 옮기는게 어떨까요!

jihyunniiii

고생하셨습니다 ~

jihyunniiii · 2024-12-16T17:36:14Z

app/src/main/java/org/sopt/and/presentation/auth/AuthViewModel.kt


 class AuthViewModel(application: Application) : AndroidViewModel(application) {

    private val context = getApplication<Application>().applicationContext


signInViewModel과 SignUpViewModel로 나누어 관리하는 것도 좋을 것 같아요! ~
(관련 내용은 합동 세미나 리뷰 페이지 참고하기!)

yihwanggeun added 18 commits December 6, 2024 19:22

#10 [FIX] BaseResponse 구조 변경

afb7302

#10 [FIX] Editor ImageCard 상단 Title 오류 수정

d04a893

#10 [ADD] Network Error Handler 공통 로직 분리

445350c

#10 [FIX] 불필요한 Data Class 삭제 및 폴더 이동

3d0c989

#10 [FEAT] DataSource 인터페이스 구현

f208a23

#10 [FEAT] DataSourceImpl 구현

ca58023

#10 [FEAT] Repository Interface 구현

1b58cf5

#10 [FEAT] RepositoryImpl 구현

d40f648

#10 [FIX] ApiService 분리

f2267b7

#10 [FEAT] ServicePool 구현

0c86067

#10 [FIX] RepositoryPool 수정

b0fb4b2

#10 [DEL] ServicePool 삭제

8ce0128

#10 [FIX] Param 타입 수정

b1f252e

#10 [FIX] BaseResponse 적용

a19e632

#10 [FIX] 아키텍처 변경에 따른 코드 수정

fc3c526

#10 [DEL] 불필요한 파일 및 Params 삭제

584d977

#10 [FIX] DataClass 이름 변경

bc20526

#10 [FIX] Return 데이터 클래스 변경

98dea2b

yihwanggeun added the enhancement New feature or request label Dec 6, 2024

yihwanggeun requested review from jihyunniiii, gitsuhyun and yskim6772 December 6, 2024 13:26

yihwanggeun self-assigned this Dec 6, 2024

yskim6772 reviewed Dec 8, 2024

View reviewed changes

gitsuhyun approved these changes Dec 8, 2024

View reviewed changes

jihyunniiii reviewed Dec 16, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FEAT/#10] 6주차 필수 과제 #11

[FEAT/#10] 6주차 필수 과제 #11

yihwanggeun commented Dec 6, 2024

yskim6772 left a comment

yskim6772 Dec 8, 2024

yskim6772 Dec 8, 2024

yskim6772 Dec 8, 2024

gitsuhyun Dec 8, 2024

yskim6772 Dec 8, 2024

gitsuhyun Dec 8, 2024

yskim6772 Dec 8, 2024

yskim6772 Dec 8, 2024

gitsuhyun left a comment

gitsuhyun Dec 8, 2024

gitsuhyun Dec 8, 2024

gitsuhyun Dec 8, 2024

gitsuhyun Dec 8, 2024

gitsuhyun Dec 8, 2024

gitsuhyun Dec 8, 2024

jihyunniiii left a comment

jihyunniiii Dec 16, 2024

		@@ -0,0 +1,8 @@
		package org.sopt.and.domain.repository

		import org.sopt.and.core.data.dto.response.CreateUserResponse


		class AuthViewModel(application: Application) : AndroidViewModel(application) {

		private val context = getApplication<Application>().applicationContext

[FEAT/#10] 6주차 필수 과제 #11

Are you sure you want to change the base?

[FEAT/#10] 6주차 필수 과제 #11

Conversation

yihwanggeun commented Dec 6, 2024

Related issue 🛠

Work Description ✏️

Screenshot 📸

Uncompleted Tasks 😅

To Reviewers 📢

yskim6772 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gitsuhyun left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jihyunniiii left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment