feat: 7주차 필수 과제 구현 #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ui -> presentation 수정
- feat(signInContract): Contract 구현 - refactor(signInViewModel): mvvm -> mvi 구조 변경
wjdrjs00
requested review from
Hyobeen-Park,
jihyunniiii,
MinseoSONG and
beom84
MinseoSONG
reviewed
Dec 19, 2024
Comment on lines
+16
to
+19
| data class OnUserNameChanged(val name: String) : Event() | ||
| data class OnUserPasswordChanged(val password: String) : Event() | ||
| data object TogglePasswordVisibility : Event() | ||
| data object OnSignInClick : Event() |
| viewModel.clearSnackbarMessage() | ||
| } | ||
| } | ||
| LaunchedEffect(viewModel.uiSideEffect, lifecycleOwner) { |
There was a problem hiding this comment.
Unit이 아닌 viewmodel.uiSideEffect를 쓰신 이유가 있을까요 ??
| ) { | ||
|
|
||
| val uiState by viewModel.uiState.collectAsStateWithLifecycle() | ||
| val lifecycleOwner = LocalLifecycleOwner.current |
There was a problem hiding this comment.
오오 .. 이건 뭔지 설명해주실 수 있을까요 ?? lifecycle을 관리하는 또다른 방법인걸까유
Comment on lines
+8
to
+10
| fun isNotBlank(): Boolean = | ||
| name.isNotBlank() && password.isNotBlank() && hobby.isNotBlank() | ||
| } |
There was a problem hiding this comment.
이건 validation 체크하는 부분 맞죠?!?? data class에서 구현하신 이유가 궁금해요!!
There was a problem hiding this comment.
추가로 서버 명세에는 8글자 이하 글자제한도 있는데 Blank만 체크하시는 이유가 궁금합니다!
| onSignInClick = { | ||
| viewModel.setEvent(SignInContract.Event.OnSignInClick) | ||
| }, | ||
| onSignUpClick = navigationToSignUp, |
There was a problem hiding this comment.
onSignUpClick은 sideEffect를 사용하지 않고 바로 화면 전환을 해주었는데 따로 이유가 있으신건지 궁금합니다!
Comment on lines
+27
to
+28
| private fun updateLogin(update: Login.() -> Login) = | ||
| setState { copy(login = login.update()) } |
There was a problem hiding this comment.
Login 네이밍을 수정해보는 것도 좋을 것 같아요! 저는 Login 이라는 이름을 처음 들었을 때는 모델보다는 함수가 더 먼저 떠올라서요!!
jihyunniiii
reviewed
Dec 25, 2024
| } | ||
| } | ||
|
|
||
| private fun updateLogin(update: Login.() -> Login) = |
There was a problem hiding this comment.
함수로 따로 분리하신 이유가 있는지 궁금해요!
| private fun updateLogin(update: Login.() -> Login) = | ||
| setState { copy(login = login.update()) } | ||
|
|
||
| private fun togglePasswordVisibility() = |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
week7.mp4
Uncompleted Tasks 😅
To Reviewers 📢