Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unduplicate frida_libpng fuzzer code using FridaRuntiemVec #2787

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

jejuisland87654
Copy link
Contributor

making most of the code in frida_libpng/fuzzer.rs shared using FridaRuntimeVec, reduced the file from 494 lines to 274

@domenukk
Copy link
Member

I wonder if the performance is different at all, since now there's dyn dispatch. I guess it shouldn't matter in practice, though

@jejuisland87654
Copy link
Contributor Author

good point, is there a convenient way to measure?

@jejuisland87654
Copy link
Contributor Author

also a possible way to tackle this is to have get_first_asan_runtime, get_first_coverage_runtime, ... and keep these objects indices instead of calling match_first_type every time

@domenukk
Copy link
Member

An alternative option to this is #2792.
Imho no matter on what option we settle (for the fuzzer.rs), we should definitely still merge the FridaRuntimeVec part of this PR. I'm a big fan of dyn dispatch for ease of use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants