Skip to content

Commit

Permalink
Removed linting step from CI. Removved linting comments. Removed lint…
Browse files Browse the repository at this point in the history
…ing dependencies. (#169)
  • Loading branch information
atteggiani authored Dec 4, 2024
1 parent cc0f2ba commit 7f21734
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 8 deletions.
4 changes: 1 addition & 3 deletions .conda/env_dev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,4 @@ dependencies:
- nccmp
- pip
- pytest
- pytest-cov
- pylint #TODO: remove this after setting up linting with ruff
- ruff
- pytest-cov
4 changes: 0 additions & 4 deletions .github/workflows/CI.yml
Original file line number Diff line number Diff line change
Expand Up @@ -97,10 +97,6 @@ jobs:
shell: bash -l {0}
run: conda list

- name: Lint
shell: bash -l {0}
run: pylint --extension-pkg-whitelist=netCDF4 --ignored-modules=um2nc -E um2nc

- name: Entrypoint test of driver script
shell: bash -l {0}
run: esm1p5_convert_nc --help
Expand Down
2 changes: 1 addition & 1 deletion src/um2nc/conversion_driver_esm1p5.py
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ def get_ff_date(fields_file_path):
header = mule.FixedLengthHeader.from_file(
str(fields_file_path))

return header.t2_year, header.t2_month, header.t2_day # pylint: disable=no-member
return header.t2_year, header.t2_month, header.t2_day


def convert_fields_file_list(input_output_paths):
Expand Down

0 comments on commit 7f21734

Please sign in to comment.