Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sonar warnings #824

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Fix sonar warnings #824

wants to merge 3 commits into from
+734 −812

Conversation

lserveriiev
Copy link
Collaborator

@lserveriiev lserveriiev commented Dec 1, 2024 •
edited
Loading

No description provided.

@thadguidry
Copy link
Collaborator

@lserveriiev At top right near Reviewers, you can convert this PR with Convert to draft. See: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/changing-the-stage-of-a-pull-request

@lserveriiev lserveriiev marked this pull request as draft December 3, 2024 07:07
@kdhrubo
Copy link
Collaborator

kdhrubo commented Dec 10, 2024

@lserveriiev ready for review ?

@lserveriiev
Copy link
Collaborator Author

@kdhrubo not yet: there is one failed test. Trying to figure out what is wrong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lserveriiev @thadguidry @kdhrubo